Repository navigation
feat: add gen_ai.agent.action_ref to trace_tool_span - #8187
Open
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 4 commits into
Open
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 4 commits into
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 4 commits into
Conversation
added 4 commits
September 4, 2026 12:15
Added a new cancellation.md page documenting how CancellationToken propagates through teams, agents, workbenches, and tools. Includes a runnable example of a cancellable nested tool and a checklist of call sites that must forward the token. Fixes microsoft#8091
Cache key was built from messages, tools, json_output, and extra_create_args only. Calls that differed only in tool_choice (e.g. auto vs none) collided and returned stale cached responses. Added tool_choice to the cache key data. For Tool objects, the serialized key uses the tool name; for string choices, the string is used directly. Fixes microsoft#7968
…string Previously, return_value_as_string fell back to str() for dict/list values, producing Python repr strings instead of valid JSON. This broke downstream agents that expected parseable structured data. Now dict and list return values are serialized with json.dumps(), matching the existing BaseModel path. Other types still use str() as a safe fallback. Fixes microsoft#7867
Added GEN_AI_AGENT_ACTION_REF constant and derive_action_ref helper for deterministic cross-producer audit correlation. Added optional action_ref parameter to trace_tool_span(). Fixes microsoft#7850
2 tasks done
Author
|
Ready for review when convenient. Happy to iterate on feedback. |
Author
|
Hi there, Sharing this PR concerning feat: add gen_ai.agent.action_ref to trace_tool_span for microsoft/autogen. Contributing around multi-agent orchestration, agent communication, and tool execution in AutoGen has been exciting, and I'd love to help out with additional improvements and features across microsoft/autogen. I am actively exploring freelance/contract engagements as well as full-time engineering positions and contributor roles. More details about my background and projects can be found on my profile: https://github.com/wasim-builds. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added
gen_ai.agent.action_refsupport totrace_tool_span()for cross-producer audit correlation.Why
Existing GenAI telemetry attributes (
gen_ai.tool.call.id,gen_ai.tool.name, etc.) are producer-scoped. Auditors comparing spans across independent runtimes have no recomputable correlation key.gen_ai.agent.action_refcloses that gap with a deterministic SHA-256 handle derived from stable action fields.Changes
GEN_AI_AGENT_ACTION_REF = "gen_ai.agent.action_ref"constantderive_action_ref(agent_id, action_type, scope, timestamp_ms)helper that returns a SHA-256 hex digest of a canonical JSON preimageaction_ref: Optional[str] = Noneparameter totrace_tool_span()autogen_coreandautogen_core._telemetryUsage
Testing
No new tests in this PR. The
derive_action_refhelper is pure and deterministic; I manually verified that repeated calls with the same inputs produce identical hashes.Fixes #7850