You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make resource switching available while the dashboard sidebar is collapsed, without reopening the full sidebar. This extracts only the resource-selector dropdown from #21793.
User-facing usage
Click the resource-name button to open the searchable resource list. Normal selection closes it; Ctrl/Cmd/Shift selection keeps it open. Selecting all closes it. Mobile retains the existing drawer.
Validation
Passed: 1,394 component tests (before the final CSS-only adjustments):
dotnet test --project tests\Aspire.Dashboard.Components.Tests\Aspire.Dashboard.Components.Tests.csproj --no-launch-profile ----filter-not-trait "quarantined=true"--filter-not-trait "outerloop=true"
Extract the resource picker from jamesnk/dashboard-resource-navigation without the other navigation or parameter-page changes. Preserve current main sidebar filtering and selection semantics. Cover selection, modifier clicks, dismissal, and the unchanged mobile drawer.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Unmounting the collapsed pane breaks all four collapse/restore motion tests, while popover sizing hides controls and incomplete resize tracking can leave activity queries disabled.
Adds a searchable resource-selector dropdown to the dashboard’s collapsed desktop sidebar, extracting that feature from #21793 while preserving the existing mobile drawer.
Changes:
Adds a toolbar picker with normal, modifier-key, and Select all selection behavior.
Integrates popover styling, dismissal, search focus, and lifecycle cleanup.
Adds component coverage and documents the new interaction.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Keyboard selection can leave focus on the document body when the picker closes; restore focus to the trigger without disrupting outside-click dismissal and add a Playwright regression test.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Restore focus to picker trigger after keyboard selection
Normal keyboard selection unmounts the focused row or Select all control before this call hides the popover, leaving focus on the document body rather than returning it to the resource-name button. Restore focus to the picker trigger on programmatic closure when focus has not moved elsewhere, while preserving outside-click dismissal behavior. Add a Playwright regression test for keyboard selection and focus restoration.
Documented the new dashboard resource-selector dropdown in dashboard/explore.mdx. Signals: pr_body_has_user_facing_section (the "User-facing usage" section) and pr_body_has_cli_flag_mention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make resource switching available while the dashboard sidebar is collapsed, without reopening the full sidebar. This extracts only the resource-selector dropdown from #21793.
User-facing usage
Click the resource-name button to open the searchable resource list. Normal selection closes it; Ctrl/Cmd/Shift selection keeps it open. Selecting all closes it. Mobile retains the existing drawer.
Validation
Screenshots / Recordings
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?