Repository navigation
Add installation validation with user notifications for JavaScript package managers - #12840
Closed
David Fowler (davidfowl) with Copilot wants to merge 3 commits into
Closed
David Fowler (davidfowl) with Copilot wants to merge 3 commits into
David Fowler (davidfowl) with Copilot wants to merge 3 commits into
Conversation
…m, yarn, pnpm) Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Aspire.Hosting.JavaScript dependencies
Add installation validation with user notifications for JavaScript package managers
Nov 8, 2025
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12840Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12840" |
…le places call with the command to validate.
7 of 14 tasks
Sébastien Ros (sebastienros)
deleted the
copilot/update-aspire-hosting-js
branch
January 15, 2026 16:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds installation validation for Node.js and JavaScript package managers (npm, yarn, pnpm) following the same pattern from #12787 for Python/uv. When commands are missing, users see notifications with installation links rather than cryptic errors.
Shared Infrastructure
CoalescingAsyncOperation.csandRequiredCommandValidator.csreferences fromsrc/Shared/as internal shared source<Compile Include="$(SharedDir)...">referencesValidation Managers
Created four installation managers extending
RequiredCommandValidator:NodeInstallationManager- validatesnodecommandNpmInstallationManager- validatesnpmcommandYarnInstallationManager- validatesyarncommandPnpmInstallationManager- validatespnpmcommandEach provides
EnsureInstalledAsync(bool throwOnFailure = true)and help links to installation docs.Integration Points
Service Registration:
NodeInstallationManagerin:AddNodeApp,AddJavaScriptApp,AddViteAppWithNpm,WithYarn,WithPnpmValidation Hooks:
OnBeforeResourceStartedhook onJavaScriptInstallerResourcethrowOnFailure: falseto show notifications without altering natural error flowBehavior
When a command is missing:
IInteractionServicewith installation linkExample notification:
Checklist
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.