Repository navigation
docs(compliance): map OWASP ASI risks for physical agent systems - #2916
Conversation
Signed-off-by: Carlos Hernandez <carloshvp@gmail.com>
PR Review Summary
Verdict: AI review comments are untrusted advisory output. The summary reports workflow-generated completion status only, not model-authored pass/fail claims. |
|
Nice work on this, Carlos Hernandez (@carloshvp)! The taxonomy correction (ASI01-ASI10 official, AGT Extension for traceability), the control boundary diagram, and the honest shipped-evidence limits section are all well done. Thanks for taking this on. One minor thing to consider: In the physical risk mapping table, the ASI04 row describes an applicable AGT control as: AGT release workflows generate and attest software SBOMs. The software section of the same document still carries a Known Gap note saying No SBOM generation or dependency vulnerability scanning is built into AGT. These refer to different things (CI/release-pipeline SBOMs vs. AGT as a product generating SBOMs for governed agents) but a reader scanning both sections could find them contradictory. A short qualifier like for AGT own release pipeline in the physical table row would make the distinction clear. Totally fine to address as a quick follow-up if you prefer to keep this PR minimal. |
Imran Siddique (imran-siddique)
left a comment
There was a problem hiding this comment.
The changes are accurate, well-scoped, and technically honest. The taxonomy correction (ASI01–ASI10), the Mermaid boundary diagram, the risk table, and the "Shipped Evidence and Limits" section are all sound. Approving with one fix request and one optional suggestion.
Fix before merge
Line 226 in the existing ASI10 section still cites agent-governance-python/agent-os/src/agent_os/services/behavior_monitor.py — that path does not exist. The new physical risk table in this PR correctly uses agent-governance-python/agent-mesh/src/agentmesh/services/behavior_monitor.py. Since this file is already being touched, please correct the stale citation to keep the doc internally consistent.
Optional suggestion
The deployment checklist doesn't address governance-service unavailability in physical deployments. A stalled policy evaluation blocking an actuator is a more acute safety scenario than the equivalent software case. Worth adding one checklist item:
Test governance-unavailable behavior — ensure a stalled policy evaluation triggers a safe stop, not a permitted actuator command.
This is already alluded to in LIMITATIONS.md §10; surfacing it in the checklist would close the loop.
Signed-off-by: Carlos Hernandez <carloshvp@gmail.com>
Head branch was pushed to by a user without write access
e9717da
Imran Siddique (imran-siddique)
left a comment
There was a problem hiding this comment.
CI green, changes addressed — merging.
d73b10b
into
microsoft:main
…rosoft#2916) * docs(compliance): map OWASP ASI risks for physical agent systems Signed-off-by: Carlos Hernandez <carloshvp@gmail.com> * docs(compliance): address physical ASI review feedback Signed-off-by: Carlos Hernandez <carloshvp@gmail.com> --------- Signed-off-by: Carlos Hernandez <carloshvp@gmail.com> Co-authored-by: Ricky Gummadi <ricky.gummadi@outlook.com>
Summary
Why
Issue #787 identified that AGT's existing OWASP mapping focused on software-only agents. After the physical-attestation example shipped, the maintainer explicitly invited a compliance mapping under
docs/compliance/for robotic and actuator systems.This profile shows how AGT can govern the software decision path before a physical command while keeping hardware interlocks, emergency stops, collision avoidance, and real-time safety controls outside AGT's scope.
Scope
Documentation only. This PR does not add robotics middleware, actuator control, hardware safety primitives, or a new roadmap commitment.
Validation
python3 scripts/docs/check_links.pypython3 scripts/docs/check_frontmatter.pypython3 examples/physical-attestation-governed/getting_started.pygit diff --checkReferences
Type of Change
Package(s) Affected
AI Assistance
Codex assisted with repository analysis, drafting, and validation; all output was reviewed and validated.
IP, Patents, and Licensing