Skip to content

Record experimental FileStore APIs as intentional omissions - #1258

Merged
Quim Muntal (qmuntal) merged 3 commits into
mainfrom
dev/mclayton/filestore-experimental-scope
Oct 6, 2026
Merged

Quim Muntal (qmuntal) merged 3 commits into
mainfrom
dev/mclayton/filestore-experimental-scope

Conversation

@michelle-clayton-work

@michelle-clayton-work Michelle Clayton (michelle-clayton-work) commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • record all public APIs from the .NET FileStore harness folder as intentional omissions
  • document that these APIs are marked MAAI001 experimental and are outside the Go 0.2.0 non-experimental harness scope
  • leave internal FileEditor and StorePaths helpers and stable FileMemory APIs outside this review

Validation

  • go run ./cmd/symbolmap mappings -summary

  • go run ./cmd/symbolmap reconcile -summary -check

  • verified zero unreviewed declarations remain for the seven public FileStore types

  • Complete .NET agent/harness port #1141

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The mappings match the pinned inventory and upstream experimental declarations.

Review effort: Balanced
Findings: None

What changed in this PR

Records experimental .NET FileStore APIs as intentional omissions from the Go harness scope.

Changes:

  • Adds pinned review provenance for the FileStore assessment.
  • Marks seven MAAI001 FileStore types and their members as intentionally omitted.
File Description
docs/​dotnet-go-sdk-symbol-mapping.json Records FileStore omission assessments and provenance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@gdams

Copy link
Copy Markdown
Member

Copilot resolve the merge conflicts in this pull request

…e-experimental-scope

# Conflicts:
#	docs/dotnet-go-sdk-symbol-mapping.json

Co-authored-by: gdams <20224954+gdams@users.noreply.github.com>
@github-actions github-actions Bot added the size:xlarge More than 300 changed lines or 10 files label Oct 6, 2026

Copilot AI commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Copilot resolve the merge conflicts in this pull request

Merged main and resolved the mapping conflict, retaining both review records. Merge commit: 3cdc1d8.

Co-authored-by: gdams <20224954+gdams@users.noreply.github.com>
@github-actions github-actions Bot added kind:dependencies Changes dependencies or manifests kind:docs Changes documentation or comments labels Oct 6, 2026
@qmuntal
Quim Muntal (qmuntal) added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit 21528e2 Oct 6, 2026
21 checks passed
@qmuntal
Quim Muntal (qmuntal) deleted the dev/mclayton/filestore-experimental-scope branch October 6, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:dependencies Changes dependencies or manifests kind:docs Changes documentation or comments size:xlarge More than 300 changed lines or 10 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants