Add C#/WinRT Projection dlls for AppLifecycle and DynamicDependency by DrusTheAxe · Pull Request #887 · microsoft/WindowsAppSDK

Howard Kapustein (DrusTheAxe) · 2021-05-29T00:36:19Z

Add C#/WinRT Projection dlls for Microsoft.Windows.AppLifecycle and Microsoft.Windows.ApplicationModel.DynamicDependency

Modeled after MRT's C#/WinRT projection dll, but accounting for MRT vs SharedProjects/ProjectReunion_DLL deltas.

As previously discussed, structured as 1 projection dll per namespace (which also matches how MRT's structured)

…icrosoft.Windows.ApplicationModel.DynamicDependency (modeled after MRT's C#/WinRT projection dll, but accounting for MRT vs SharedProjects/ProjectReunion_DLL deltas)

Howard Kapustein (DrusTheAxe) · 2021-05-29T00:39:07Z

/azp

azure-pipelines · 2021-05-29T00:39:12Z

Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

Howard Kapustein (DrusTheAxe) · 2021-05-29T00:48:13Z

+    <PackageReference Include="Microsoft.Windows.CsWinRT" Version="1.2.2" />
+  </ItemGroup>
+
+  <!-- For consistency across Reunion, explicitly reference .NET 5.0.5 SDK (5.0.202 train for VS 16.9.3) -->


MRTCore had this which is puzzling AH as I don't see any mention of .NET 5.0.5, 5.0.202 or VS 16.9.3 in the <FrameworkReference>s below.

And this sort of this would be best commonly defined for the repo e.g. in Directory.build.props

... <PropertyGroup> <ProjectReunion_CsWinRT_Projections_RuntimeFrameworkVersion>10.0.18362.16</> <ProjectReunion_CsWinRT_Projections_TargetingPackVersion>10.0.18362.16</> ...

and use the common definitions across the repository

... <FrameworkReference Update="Microsoft.Windows.SDK.NET.Ref" RuntimeFrameworkVersion="$(ProjectReunion_CsWinRT_Projections_RuntimeFrameworkVersion)"/> <FrameworkReference Update="Microsoft.Windows.SDK.NET.Ref" TargetingPackVersion="ProjectReunion_CsWinRT_Projections_TargetingPackVersion" /> ...

Even better: instead of defining versions in Directory.Build.props, create a new Tools.props in the root with the tool versions (similar to BuildInfo.json generated by the build pipeline) and Directory.Build.props merely includes it.

those versions are wrong.
The SDK refs are probably unnecessary.

Scott Jones (@Scottj1s) can we drop the Microsoft.Windows.SDK.NET.Ref snippets?

remove the framework reference overrides in a component - those are needed by an app for a temporary situation to avoid mem leaks that were fixed in the .16 update. That will come to all apps by default in the next .NET5 SDK update

Howard Kapustein (DrusTheAxe) · 2021-05-29T00:48:57Z

/azp run

azure-pipelines · 2021-05-29T00:49:09Z

Azure Pipelines successfully started running 1 pipeline(s).

Hui Chen (huichen123) · 2021-05-29T00:56:19Z

 		{A3FBA80D-5B35-471F-9A45-DB4B29E195B9}.Release|x86.ActiveCfg = Release|x86
 		{A3FBA80D-5B35-471F-9A45-DB4B29E195B9}.Release|x86.Build.0 = Release|x86
 		{A3FBA80D-5B35-471F-9A45-DB4B29E195B9}.Release|x86.Deploy.0 = Release|x86
+		{4995CCDC-9B83-4A9A-9724-604B09E6AF00}.Debug_test|Any CPU.ActiveCfg = Debug|x64


Debug_test

remove

What is Debug_test for anyway? Looks like everything's got them but we never use them (that I know of). Delete them all?

uhh, i thought you added that. But it's existing. It does change IsTDPConfiguration to true, although nobody seems to use IsTDPConfiguration. I guess it's ok to leave it alone.

Any idea what Debug_test is for? I never saw it before last year in ProjectReunion.sln.

I added the project via VS on a PC which I think doesn't have TDP installed, if that matters

related to TAEF testing configurations? if it looks like cruft, I'd drop it

Drop all of them or just these additions?

…o 10.0.17763.0 (MRT's been overdue for the update)

Scott Jones (Scottj1s) · 2021-06-03T16:17:43Z

+  <assembly>
+    <name>Microsoft.Windows.AppLifecycle.Projection</name>
+  </assembly>
+  <members>


you don't need an Intellisense xml file for the managed projection assembly - VS just uses reflection

EDIT: oops, correction - we do need these for projection assemblies as well. If you have IDL comments, might be able to powershell those into an xml file. The Windows SDK projection assembly contains Microsoft.Windows.SDK.NET.xml, but I could not find where that lives. Manodasan Wignarajah (@manodasanW) might know, but would likely still require hand-editing.

Cool. I see MRTCore's got one too -- dev\MRTCore\packaging\Intellisense. I'll delete that too (unlesss Hui Chen (@huichen123) Axel Andrejs (@axelandrejs) squeak otherwise)

please remove for MRT. Thanks.

Per Scott Jones (@Scottj1s) correction these are needed. They should be fleshed out (need content, not just a trivial file as listed). I'll take a stab at it in a future PR per DynamicDependencies: Flesh out Intellisense .xml with doccomments
#906

There's some potential tooling to help. Once I figure it out we should be able to do likewise for AppLifecycle and MRTCore (if when :-) they contain doccomments)

Scott Darnell (@aeloros) Hui Chen (@huichen123) do AppLifecycle and MRTCore have tasks for 1.0 to add doccomments?
(I did added them for DynDep when I created the APIspec, easy and self-documenting. But easy enough to add after the fact too)

Scott Jones (Scottj1s) · 2021-06-03T18:18:52Z

The intellisense data might be an issue in its own right - consider opening an IOU and dropping comment pointers to it in each xml file.

Howard Kapustein (DrusTheAxe) · 2021-06-03T18:27:22Z

I created an issue for 1.0 DynamicDependencies: Flesh out Intellisense .xml with doccomments
#906

We can use that as the stalking horse to figure it out as that's already got all the doccomment/content, just a matter of working out process/mechanism to pass that along to Intellisense.

AppLifecycle and MRTCore should add doccomments. Then whatever the process we work out for DynDep we can apply to them too for full coverage

AdamBr (AdamBraden) · 2021-06-04T15:24:17Z

  <PropertyGroup>
    <TargetFramework>net5.0-windows10.0.18362.0</TargetFramework>
-    <TargetPlatformMinVersion>10.0.17134.0</TargetPlatformMinVersion>
+    <TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>


Why do we need to set TFM and TPMinV differently for our projections? Shouldn't we just set TFM=17763? I don't believe the projections (or the component itself) does any lightup on 18362?

AdamBr (AdamBraden) · 2021-06-04T15:24:39Z

    <TargetFramework>net5.0-windows10.0.18362.0</TargetFramework>
-    <TargetPlatformMinVersion>10.0.17134.0</TargetPlatformMinVersion>
+    <TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>
    <Platforms>x64;x86</Platforms>


AdamBr (AdamBraden) · 2021-06-04T15:26:01Z

@@ -17,8 +17,8 @@
    <ApplicationType>Windows Store</ApplicationType>
    <ApplicationTypeRevision>10.0</ApplicationTypeRevision>
    <WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.18362.0</WindowsTargetPlatformVersion>


same as above - can't all this be 17763 or does the component actually do lightup?

AdamBr (AdamBraden) · 2021-06-04T15:26:49Z

+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>net5.0-windows10.0.18362.0</TargetFramework>


set TFM=17763 and remove the TPMinV

AdamBr (AdamBraden) · 2021-06-04T15:27:05Z

+  <PropertyGroup>
+    <TargetFramework>net5.0-windows10.0.18362.0</TargetFramework>
+    <TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>
+    <Platforms>x64;x86</Platforms>


AdamBr (AdamBraden) · 2021-06-04T15:30:36Z

+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>net5.0-windows10.0.18362.0</TargetFramework>


set TFM=17763 unless it requires a newer api, remove TPMinV
add arm64 platform support

AdamBr (AdamBraden) · 2021-06-04T15:31:42Z

+  </ItemGroup>
+
+  <!-- For consistency across Reunion, explicitly reference .NET 5.0.5 SDK (5.0.202 train for VS 16.9.3) -->
+  <ItemGroup>


remove the frameworkreference overrides. this should only be specified by apps and is temporary until the next netsdk update

Howard Kapustein (DrusTheAxe) · 2021-08-10T06:09:35Z

Abandoning due to too old and stale to merge correctly. Replaced by Added C# WinRT projections for DynamicDependency and AppLifecycle WinRT APIs #1208

Add C#/WinRT Projection dlls for Microsoft.Windows.AppLifecycle and M…

4cd0075

…icrosoft.Windows.ApplicationModel.DynamicDependency (modeled after MRT's C#/WinRT projection dll, but accounting for MRT vs SharedProjects/ProjectReunion_DLL deltas)

Howard Kapustein (DrusTheAxe) added this to the 1.0 (2021 Q4) milestone May 29, 2021

Howard Kapustein (DrusTheAxe) self-assigned this May 29, 2021

ghost added the needs-triage label May 29, 2021

Howard Kapustein (DrusTheAxe) requested review from andreww-msft and removed request for Andrew Leader (andrewleader) May 29, 2021 00:37

Howard Kapustein (DrusTheAxe) commented May 29, 2021

View reviewed changes

Hui Chen (huichen123) reviewed May 29, 2021

View reviewed changes

Comment thread build/CopyFilesToStagingDir.ps1

Hui Chen (huichen123) reviewed May 29, 2021

View reviewed changes

Comment thread ...ojections/CS/Microsoft.Windows.AppLifecycle/Microsoft.Windows.AppLifecycle.Projection.csproj Outdated

Hui Chen (huichen123) reviewed May 29, 2021

View reviewed changes

Comment thread ...del.DynamicDependency/Microsoft.Windows.ApplicationModel.DynamicDependency.Projection.csproj Outdated

Bump MRT + new Project projects' TargetPlatformVersion=10.0.17134.0 t…

ce99cac

…o 10.0.17763.0 (MRT's been overdue for the update)

Howard Kapustein (DrusTheAxe) requested a review from astritz June 1, 2021 19:36

Scott Jones (Scottj1s) reviewed Jun 3, 2021

View reviewed changes

Howard Kapustein (DrusTheAxe) mentioned this pull request Jun 3, 2021

DynamicDependencies: Flesh out Intellisense .xml with doccomments #906

Closed

AdamBr (AdamBraden) reviewed Jun 4, 2021

View reviewed changes

Howard Kapustein (DrusTheAxe) mentioned this pull request Aug 10, 2021

Added C# WinRT projections for DynamicDependency and AppLifecycle WinRT APIs #1208

Merged

Howard Kapustein (DrusTheAxe) closed this Aug 10, 2021

Conversation

Howard Kapustein (DrusTheAxe) commented May 29, 2021

Uh oh!

Howard Kapustein (DrusTheAxe) commented May 29, 2021

Uh oh!

azure-pipelines Bot commented May 29, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Howard Kapustein (DrusTheAxe) commented May 29, 2021

Uh oh!

azure-pipelines Bot commented May 29, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Scott Jones (Scottj1s) Jun 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Howard Kapustein (DrusTheAxe) Jun 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Scott Jones (Scottj1s) commented Jun 3, 2021

Uh oh!

Howard Kapustein (DrusTheAxe) commented Jun 3, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Howard Kapustein (DrusTheAxe) commented Aug 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Scott Jones (Scottj1s) Jun 3, 2021 •

edited

Loading

Howard Kapustein (DrusTheAxe) Jun 3, 2021 •

edited

Loading