Rename ProjectReunion -> WindowsAppSDK - #1041
Merged
Merged
Conversation
Howard Kapustein (DrusTheAxe)
requested review from
AdamBr (AdamBraden),
Ben Kuhn (BenJKuhn),
Scott Jones (Scottj1s),
Scott Darnell (aeloros),
alexlamtest,
Andrew Leader (andrewleader),
andreww-msft,
Axel Andrejs (axelandrejs),
David Bennett (dkbennett),
Hui Chen (huichen123),
Pavan Hullumane (hulumane),
Huzaifa Danish (huzaifa-d),
Kyaw Thant (kythant) and
zaryaf
July 9, 2021 06:39
Member
Author
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Member
Author
Best to handle in a follow up PR. Thanks! |
Member
Author
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Howard Kapustein (DrusTheAxe)
requested a review
from Andrew Leader (andrewleader)
July 16, 2021 00:48
Member
Author
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Howard Kapustein (DrusTheAxe)
dismissed
Andrew Leader (andrewleader)’s stale review
July 16, 2021 05:30
Issues were addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the repository per the name change (only some docs were changed before, now change the rest - DLLs, etc).
Naming rules:
So sweep through the repository changing e.g. "Project Reunion" -> "Windows App SDK", "ProjectReunion" -> "WindowsAppSDK" plus case variations e.g. PROJECTREUNION_FOO -> WINDOWSAPPSDK_FOO.
This change applies to filenames as well as content.
NOTE: This only changes this repository. The aggregator pipeline also needs changes to match. That'll be a separate PR to the build system (i.e. not here).
Internal source code references weren't strictly required for this task but identifying the artifacts needing changes and all their related references and machinery is complicated, so it was easier to just do a full pass through the repository and update everything. As a perk we won't have folks asking 10 years from now "This code says Project Reunion. What is that?" :-)
This doesn't change any mention of Reunion in the ADO repository's backend definitions. The build pipelines are all *.yml so were updated, but if the ADO build definition says Reunion it'll need ES changes to the ADO instance.
There are a few references left:
#1 build\Helix\RunTestsInHelix.proj
<HelixSource>pr/reunion/$(BUILD_SOURCEBRANCH)/</HelixSource>references a backend artifact (branch?)alexlamtest for follow up after this PR completes
#2 dev\MRTCore\mrt\Microsoft.Windows.ApplicationModel.Resources\src\Microsoft.Windows.ApplicationModel.Resources.vcxproj
#3 dev\MRTCore\mrt\Microsoft.Windows.ApplicationModel.Resources\src\packages.config
'reunion' appears in version namaes for FrameworkUDK e.g.
This should go away when newer FrameworkUDK's are adopted
Axel Andrejs (@axelandrejs) Ben Kuhn (@BenJKuhn) for follow up
#4 dev\VSIX\Directory.Build.props
This will go away when the NuGet feed's name is changed.
Ben Kuhn (@BenJKuhn) for follow up
#5 installer\dev\console.cpp
There's a reference to
https://aka.ms/ProjectReunionInstallerwhich should behttps://aka.ms/WindowsAppSDKInstallerbut that doesn't resolve. Can be updated at a future data once the URL's available.David Bennett (@dkbennett) zaryaf for follow up
#6 README.md
*Previously known as Project Reunion*.is a historical reference which expected (the only one that should stay, at least for the foreseeable future).