Simplify getRangeOfEnclosingComment - #25168
Merged
2 commits merged intoJun 29, 2018
Merged
Conversation
ghost
force-pushed
the
getRangeOfEnclosingComment
branch
3 times, most recently
from
June 25, 2018 17:43
c71a3e3 to
2593348
Compare
ghost
requested a review
from Ben Lichtman (uniqueiniquity)
June 25, 2018 17:43
ghost
force-pushed
the
getRangeOfEnclosingComment
branch
from
June 26, 2018 20:24
2593348 to
410c3d2
Compare
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findinstead of manual loop.onlyMultiLineandpredicateas parameters; can just filter the result if needed.