Stack overflow in TS 4.5.3 and nightly #47142

Activity

1. DanielRosenwasser commented on Dec 14, 2021

   

   Daniel Rosenwasser (DanielRosenwasser)

   on Dec 14, 2021

   Last edited by DanielRosenwasser

   MemberAuthor

   More actions

   If you open up tsc.js and add the following line to the top of checkTypeRelatedTo

   console.log(`Checking if ${typeToString(source)} is related to ${typeToString(target)}`);

   that might give you an indication of where things are going off the rails, and will help us come up with a repro and possible fix.
2. Daniel Rosenwasser (DanielRosenwasser)

   added

   Needs More InfoThe issue still hasn't been fully clarifiedThe issue still hasn't been fully clarified

   on Dec 14, 2021
3. Daniel Rosenwasser (DanielRosenwasser)

   changed the title [-]Stack Overflow in TS 4.5.3 and nightly[/-] [+]Stack overflow in TS 4.5.3 and nightly[/+] on Dec 14, 2021
4. sloonz commented on Dec 17, 2021

   

   Simon Lipp (sloonz)

   on Dec 17, 2021

   More actions

   Simplest repro I could do :

   import {Model} from "objection";
   
   export class Organization extends Model {
     id!: number;
     users?: User[];
   
     static get relationMappings() {
       return {
         users: {relation: Model.HasManyRelation, modelClass: User, join: {from: "organizations.id", to: "users.organizationId"}},
       };
     }
   }
   
   export class User extends Model {
     id!: number;
     organizationId!: number;
     organization?: Organization;
   
     static get relationMappings() {
       return {
         organization: {relation: Model.BelongsToOneRelation, modelClass: Organization, join: {from: "users.organizationId", to: "organizations.id"}},
       };
     }
   }

   package.json :

   {"name":"tscbug","dependencies":{"objection":"^3.0.0","typescript":"^4.5.3"}}

   tsconfig.json (nothing fancy, generated by tsc --init) :

   {
     "compilerOptions": {
       "target": "es2016",                                  /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
       "module": "commonjs",                                /* Specify what module code is generated. */
       "esModuleInterop": true,                             /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables `allowSyntheticDefaultImports` for type compatibility. */
       "forceConsistentCasingInFileNames": true,            /* Ensure that casing is correct in imports. */
       "strict": true,                                      /* Enable all strict type-checking options. */
       "skipLibCheck": true                                 /* Skip type checking all .d.ts files. */
     }
   }
   

   👍React with 👍1Reacted by Gabriela Araujo Britto
5. DanielRosenwasser commented on Dec 17, 2021

   

   Daniel Rosenwasser (DanielRosenwasser)

   on Dec 17, 2021

   MemberAuthor

   More actions

   Thank you for the repro! That'll help us expedite a fix, though a lot of people are going to be out for a bit, so please be patient.
6. Daniel Rosenwasser (DanielRosenwasser)

   added

   CrashFor flagging bugs which are compiler or service crashes or unclean exits, rather than bad outputFor flagging bugs which are compiler or service crashes or unclean exits, rather than bad output

   on Dec 17, 2021
7. Daniel Rosenwasser (DanielRosenwasser)

   assigned

   Anders Hejlsberg (ahejlsberg)

   on Jan 6, 2022
8. ahejlsberg commented on Jan 7, 2022

   

   Anders Hejlsberg (ahejlsberg)

   on Jan 7, 2022

   Member

   More actions

   I bisected using the repro. This appears to be yet another casualty of #30639. That said, we should of course never overflow the stack. I can fix that, but when I do we now report an Excessive stack depth comparing types 'UpsertGraphMethod<?>' and 'UpsertGraphMethod<?>' error. Effectively, attempting to compute variance for the UpsertGraphMethod type ends up spiraling forever (because with #30639 we keep exploring assignability to a conditional type on the target side).
9. ahejlsberg commented on Jan 7, 2022

   

   Anders Hejlsberg (ahejlsberg)

   on Jan 7, 2022

   Member

   More actions

   Wesley Wigham (@weswigham) Any ideas here?
10. ahejlsberg commented on Jan 7, 2022

    

    Anders Hejlsberg (ahejlsberg)

    on Jan 7, 2022

    Member

    More actions

    Actually, with a couple of minor fixes (without which the variance computation for UpsertGraphMethod runs amok) the repro now compiles as it did with 4.2. I will put up a PR.
11. Anders Hejlsberg (ahejlsberg)

    added

    BugA bug in TypeScriptA bug in TypeScript

    Fix AvailableA PR has been opened for this issueA PR has been opened for this issue

    and removed

    Needs More InfoThe issue still hasn't been fully clarifiedThe issue still hasn't been fully clarified

    on Jan 7, 2022
12. Anders Hejlsberg (ahejlsberg)

    closed this as completedin #47341on Jan 7, 2022
13. microsoft

    locked as resolved and limited conversation to collaborators on Oct 22, 2025