Language service crash in 'displayPartKind' #12166

Activity

1. Daniel Rosenwasser (DanielRosenwasser)

   added

   BugA bug in TypeScriptA bug in TypeScript

   on Nov 11, 2016
2. Daniel Rosenwasser (DanielRosenwasser)

   changed the title [-]Language service crash[/-] [+]Language service crash in 'displayPartKind'[/+] on Nov 11, 2016
3. ahejlsberg commented on Nov 11, 2016

   

   Anders Hejlsberg (ahejlsberg)

   on Nov 11, 2016

   Member

   More actions

   Daniel Rosenwasser (@DanielRosenwasser) Repro?
4. DanielRosenwasser commented on Nov 11, 2016

   

   Daniel Rosenwasser (DanielRosenwasser)

   on Nov 11, 2016

   MemberAuthor

   More actions

   Mohamed Hegazy (@mhegazy) told me to just file this and we'll discuss offline.
5. nickytonline commented on Nov 30, 2016

   

   Nick Taylor (nickytonline)

   on Nov 30, 2016

   Last edited by nickytonline

   More actions

   I'm able to produce this error by destructuring arguments two levels deep, e.g.

   import * as React from 'react';
   
   interface SomeInterface {
   	someBoolean: boolean,
   	someString: string;
   }
   
   interface SomeProps {
     someProp: SomeInterface;
   }
   
   export const SomeStatelessComponent = ({someProp: { someBoolean, someString}}: SomeProps) => (<div>{`${someBoolean}${someString}`}</div>);
   

   but if I destruct just the top level, e.g. someProp, it works

   export const SomeStatelessComponent = ({someProp}: SomeProps) => (<div>{`${someProp.someBoolean}${someProp.someString}`}</div>);
   
6. Mohamed Hegazy (mhegazy)

   assigned

   Sheetal Nandi (sheetalkamat)

   on Dec 1, 2016
7. Mohamed Hegazy (mhegazy)

   added this to the TypeScript 2.2 milestone on Dec 1, 2016
8. Sheetal Nandi (sheetalkamat)

   added a commit that references this issue on Dec 6, 2016

   Write property name of destructuring pattern explicitly

   ...

   This issue will close once commit 7d049c2 is merged into the 'main' branch.

   7d049c2
9. Sheetal Nandi (sheetalkamat)

   closed this as completedin #12691on Dec 6, 2016
10. Sheetal Nandi (sheetalkamat)

    added

    FixedA PR has been merged for this issueA PR has been merged for this issue

    on Dec 6, 2016
11. Mohamed Hegazy (mhegazy)

    modified the milestones: TypeScript 2.2, TypeScript 2.1.5 on Dec 13, 2016
12. microsoft

    locked and limited conversation to collaborators on Jun 19, 2018