Skip to content

Re-do the esmoduleinterop docs - #873

Merged
Orta Therox (orta) merged 2 commits into
v2from
esmoduleint_docs
Aug 7, 2020
Merged

Orta Therox (orta) merged 2 commits into
v2from
esmoduleint_docs

Conversation

@orta

Copy link
Copy Markdown
Contributor

I think they weren't clear enough, and I had mixed some of allowSyntheticDefaultImport's docs in there

@github-actions

github-actions Bot commented Aug 7, 2020

Copy link
Copy Markdown
Contributor
Messages
📖

Deployed to a PR branch - playground tsconfig old handbook

Got false positives?

Make changes to the global settings spellcheck.json in /artsy/peril-settings.

Typos for esModuleInterop.md

Line Typo
6 or not set) TypeScript treats CommonJS/AMD/UMD modules similar to ES
12 This mis-match causes these two issues:
14 - the ES6 modules spec states that a namespace impor
15 be callable. This breaks the spec's recommendations.
17 e accurate to the ES6 modules spec, most libraries with CommonJS
17 les spec, most libraries with CommonJS/AMD/UMD modules didn't confor
19 Script. The first changes the behavior in the compiler,the second is

Typos for allowSyntheticDefaultImports.md

Line Typo
56 This option brings the behavior of TypeScript in-line with Ba

Generated by 🚫 dangerJS against 2e3a872

@orta

Copy link
Copy Markdown
Contributor Author

@orta

Copy link
Copy Markdown
Contributor Author

I'm happy that this is an improvement, open to feedback and I can edit the docs in a new PR

@orta
Orta Therox (orta) merged commit e244cf8 into v2 Aug 7, 2020
@jakebailey
Jake Bailey (jakebailey) deleted the esmoduleint_docs branch May 17, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant