Remove graph related overhead from data storage - #7712
Merged
Jens Hedegaard Nielsen (jenshnielsen) merged 12 commits intoDec 12, 2025
Merged
Remove graph related overhead from data storage#7712Jens Hedegaard Nielsen (jenshnielsen) merged 12 commits into
Jens Hedegaard Nielsen (jenshnielsen) merged 12 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7712 +/- ##
==========================================
+ Coverage 59.77% 59.79% +0.01%
==========================================
Files 352 352
Lines 31688 31788 +100
==========================================
+ Hits 18942 19007 +65
- Misses 12746 12781 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Copilot started reviewing on behalf of
Jens Hedegaard Nielsen (jenshnielsen)
December 12, 2025 13:00
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces performance optimizations to the dataset storage system by creating a frozen, immutable version of InterDependencies_ that caches expensive graph-related lookups. The changes aim to reduce overhead when storing data by avoiding repeated graph traversals.
Key Changes
- Introduced
FrozenInterDependencies_class that wrapsInterDependencies_with immutability and caching of expensive operations - Extracted
_invalid_subsetshelper method fromvalidate_subsetto enable caching in the frozen implementation - Modified
Measurement.run()to useFrozenInterDependencies_instead of mutableInterDependencies_
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/qcodes/dataset/measurements.py | Updated to wrap interdependencies in FrozenInterDependencies_ when creating a Runner, and added import for the new class |
| src/qcodes/dataset/descriptions/dependencies.py | Added FrozenInterDependencies_ class with caching for properties and methods, extracted _invalid_subsets helper method, and implemented immutability constraints |
Jens Hedegaard Nielsen (jenshnielsen)
force-pushed
the
improve_speed
branch
from
December 12, 2025 13:36
df0f207 to
1543802
Compare
Jens Hedegaard Nielsen (jenshnielsen)
marked this pull request as ready for review
December 12, 2025 14:38
Jens Hedegaard Nielsen (jenshnielsen)
requested a review
from a team
as a code owner
December 12, 2025 14:38
Mikhail Astafev (astafan8)
approved these changes
Dec 12, 2025
Jens Hedegaard Nielsen (jenshnielsen)
enabled auto-merge
December 12, 2025 14:52
Jens Hedegaard Nielsen (jenshnielsen)
added a commit
that referenced
this pull request
Dec 12, 2025
Remove graph related overhead from data storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.