Add more explicit channel atttributes - #7641
Closed
Jens Hedegaard Nielsen (jenshnielsen) wants to merge 3 commits into
Closed
Add more explicit channel atttributes#7641Jens Hedegaard Nielsen (jenshnielsen) wants to merge 3 commits into
Jens Hedegaard Nielsen (jenshnielsen) wants to merge 3 commits into
Conversation
Jens Hedegaard Nielsen (jenshnielsen)
requested a review
from a team
as a code owner
November 13, 2025 09:40
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7641 +/- ##
==========================================
- Coverage 59.78% 59.74% -0.05%
==========================================
Files 352 352
Lines 31659 31681 +22
==========================================
Hits 18927 18927
- Misses 12732 12754 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jens Hedegaard Nielsen (jenshnielsen)
force-pushed
the
jenshnielsen/add_channel_type
branch
from
December 3, 2025 08:26
ceb739e to
2b33205
Compare
Mikhail Astafev (astafan8)
approved these changes
Dec 3, 2025
| ) -> MultiChannelInstrumentParameter | Callable[..., None] | InstrumentModuleType: | ||
| def multi_parameter( | ||
| self: Self, name: str | ||
| ) -> MultiChannelInstrumentParameter[InstrumentModuleType]: |
Collaborator
Author
There was a problem hiding this comment.
Need to add test coverage for this code + changelog
Collaborator
Author
|
Moved the pr here #7686 to experiment with copilot |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards more strongly typed instruments