This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Specify workflow URLs as a URL string to Cromwell instead of downloading - #522
Open
Matt McLoughlin (MattMcL4475) wants to merge 13 commits into
Open
Specify workflow URLs as a URL string to Cromwell instead of downloading#522Matt McLoughlin (MattMcL4475) wants to merge 13 commits into
Matt McLoughlin (MattMcL4475) wants to merge 13 commits into
Conversation
Matt McLoughlin (MattMcL4475)
requested review from
Blair L Murri (BMurri) and
jlester-msft
and removed request for
Blair L Murri (BMurri) and
jlester-msft
October 26, 2022 00:27
Blair L Murri (BMurri)
added
the
Needs Issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the trigger service downloads the workflow source file and then provides it as a byte array to Cromwell. This can break WDL imports, so this change will specify the workflow URL as a URL (and not download), and allow Cromwell to resolve the imports and download the workflow.