Repository navigation
Allow metric telemetry properties to be set - #3251
Merged
Matthew Sainsbury (Microsoft) (mattsains-msft) merged 3 commits intoNov 19, 2026
Merged
Matthew Sainsbury (Microsoft) (mattsains-msft) merged 3 commits into
Matthew Sainsbury (Microsoft) (mattsains-msft) merged 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change initializing metric properties so callers can add custom values.
No open issues 🎉
What changed in this PR
Fixes issue #3243 by initializing MetricTelemetry.Properties, allowing SDK users to add custom metric properties instead of encountering a null dictionary.
Changes:
- Initializes an empty
Dictionary<string, string>in the metric constructor.
| File | Description |
|---|---|
BASE/src/Microsoft.ApplicationInsights/DataContracts/MetricTelemetry.cs |
Initializes the metric properties dictionary so callers can populate it. |
Review effort: Balanced
Rajkumar Rangaraj (rajkumar-rangaraj)
approved these changes
Nov 19, 2026
Rajkumar Rangaraj (rajkumar-rangaraj)
approved these changes
Nov 19, 2026
Matthew Sainsbury (Microsoft) (mattsains-msft)
force-pushed
the
3243
branch
from
November 19, 2026 18:52
47800bc to
79ae10e
Compare
Rajkumar Rangaraj (rajkumar-rangaraj)
approved these changes
Nov 19, 2026
Matthew Sainsbury (Microsoft) (mattsains-msft)
enabled auto-merge (squash)
November 19, 2026 19:00
Matthew Sainsbury (Microsoft) (mattsains-msft)
merged commit Nov 19, 2026
5dc3242
into
microsoft:main
20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #3243
Changes
Initializes the Properties object of the MetricTelemetry class so that users can set metric telemetry properties.
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors: