Skip to content

FIX add pipe to prohibited domain characters #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phoet merged 1 commit into from
Aug 23, 2026
+6 −1
Merged

FIX add pipe to prohibited domain characters #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/valid_email2/address.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module ValidEmail2
class Address
attr_accessor :address

PROHIBITED_DOMAIN_CHARACTERS_REGEX = /[+!_\/\s'#`]/
PROHIBITED_DOMAIN_CHARACTERS_REGEX = /[+!_\/\s'#`|]/
DEFAULT_RECIPIENT_DELIMITER = '+'
DOT_DELIMITER = '.'
HYPHEN_DELIMITER = '-'
Expand Down
5 changes: 5 additions & 0 deletions spec/address_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@
expect(address.valid?).to be false
end

it "is invalid if email contains a pipe" do
address = described_class.new("foo@gmai|.com")
expect(address.valid?).to be false
end

it "is invalid if it contains Japanese characters" do
address = described_class.new("あいうえお@example.com")
expect(address.valid?).to be false
Expand Down
Loading