Repository navigation
Fix/dropdown menu trigger - #8
JoaoTMDias wants to merge 8 commits into
Conversation
|
The initial Playwright setup is ready in this PR. It keeps the existing Astro checks, build, and CLI smoke tests unchanged, while adding focused browser coverage for component behaviour. When you have time, could you please review the approach and let me know if you’d prefer any changes before I expand the coverage? Thanks! P.S. I also have a draft PR based on this one. It fixes an issue with the dropdown trigger and adds focused tests for that behaviour. |
|
The dropdown fix itself is great and I'd like to merge it. A single native button is the right call, and since components are installed as source, the API change is fine with a note in the changelog. Since I'm not adding Playwright (see #7), could you rebase this onto Also, please re-run Thanks! |
Summary
DropdownMenuTriggernow renders one native<button>instead of a focusable<span>wrapper.This fixes incorrect button semantics, nested interactive controls, and inconsistent keyboard/focus behaviour.
Changes
Buttoncomponent API and icon slots.type="button".disabled,event.defaultPrevented, ArrowUp and ArrowDown.Buttoncomposition.buttonas a dropdown registry dependency.Verification
npm run check✅npm run build✅Breaking change
Consumers using:
must migrate to
Button props now belong directly on DropdownMenuTrigger.
Note: Issues are disabled in this repository, so this PR has no linked issue.