Skip to content

feat: add searchable entity pickers - #640

Closed
mforce wants to merge 5 commits into
mainfrom
001-searchable-entity-picker
Closed

mforce wants to merge 5 commits into
mainfrom
001-searchable-entity-picker

Conversation

@mforce

@mforce mforce commented Sep 2, 2026 •

Copy link
Copy Markdown
Owner

What and why

Adds paged literal-search APIs and accessible flock/customer pickers so users can find entities beyond the first page without silently selecting the wrong record. Page displays now use row-owned names/status, and Sales customer filtering is URL-owned and history-safe.

Draft checkpoint for #512: 66 of 67 tasks are complete. The remaining task is the required first-time-user protocol with one keyboard participant and one pointer participant who did not implement the picker.

Closes #512.

How it was verified

  • dotnet build Cluckwork.sln: clean, 0 warnings/errors.
  • dotnet test Cluckwork.sln --no-build: 2,252 passed.
  • cd web && npm run test:coverage: 2,197 passed; thresholds passed (90.32% statements, 85.20% branches, 85.14% functions, 93.36% lines).
  • cd web && npm run build && npm run verify:sw: production build and service-worker contract passed.
  • tools/schema-docs/generate.sh --check: schema docs current.
  • cd tools/simulation/ui && npm run typecheck: clean.
  • Rebuilt simulation-stack Playwright smoke: 41 passed, 1 intentionally skipped, 0 failed; the focused Add a reusable searchable paged entity picker for flock and customer selectors #512 scenario passed 3/3.
  • Picker pagination mutation check: baseline green, mutant killed the sentinel assertion, restored baseline green.
  • npm run i18n:scan and git diff --check: clean/advisory output inspected.

Human verification still required

  • Keyboard participant independently selects both late-sorting sentinels and completes Retry recovery with no wrong selection.
  • Pointer participant independently selects both late-sorting sentinels and completes Retry recovery with no wrong selection.

Checklist

  • The PR title is a conventional commit and the intended release note.
  • Automated tests cover the implementation slices, and new guards were mutation-checked.
  • User-facing docs were updated in the product glossary and SPA Help page.
  • No hardcoded credential or hosting-provider name was added.
  • No migration, schema, package/lockfile, fixture/manifest, simulation harness, compose/bootstrap, or CI workflow change was introduced.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@mforce

mforce commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

Superseded by spec-only PR #641 and implementation PR #642 so the feature contract can be reviewed separately from the code. The original branch is retained for traceability.

@mforce mforce closed this Sep 2, 2026
@mforce
mforce deleted the 001-searchable-entity-picker branch September 14, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a reusable searchable paged entity picker for flock and customer selectors

1 participant