Repository navigation
ci: add an image summary check and record main's required checks - #1188
Conversation
A job-level if: skips the image matrix before its names expand, so a docs-only PR reports no (amd64)/(arm64) check and could never satisfy a ruleset requiring them. Image build + smoke test passes only when both legs succeeded or the PR is documentation-only, and fails closed otherwise. Also drop ci.yml's stale claim that main requires no checks.
|
Review round 1 came from Codex (gpt-6-astra): one P1, one P2 and one P3. Head is 1. P1: docs-only PRs never report the two required image checks. Confirmed. The job-level 2. P2: the 3. P3: |
Closes #1182
Why
The maintainer turned on the ruleset "Main required checks" (id 24852475): required
ci.ymlchecks, pinned to the GitHub Actions app, and "require branches to be up to date". It exists because #1162 merged green against amainthat predated #1155's lint rule, andmainstayed red at3e879b0cuntil #1176. Two documents still saidmainhas no required status checks, and nothing in the repository recorded the rule or what breaks it.The ruleset first required
Image build + smoke test (amd64)and(arm64). A documentation-only PR never reports those names: theimagejob's job-levelif:skips the matrix before its names expand, so it reports one check namedImage build + smoke test (${{ matrix.arch }})(run 37552204234). The two names were removed from the ruleset on 2026-10-10, leaving six checks. This PR adds a stable-named job so image enforcement can come back as a seventh.Scope
ci.yml: a newimage-summaryjob namedImage build + smoke test. It needschangesandimageand runs underalways(). It passes when every image leg succeeded, or whenimagewas skipped on a documentation-only PR. Any other skip, a cancellation or a failure fails it. It is not inpublish.needs. The stale comment sayingmainhas no required checks is corrected.docs/decisions/351-releases.mdand the matching comment inrelease-please.yml: the release token's ability to approve a PR is still inert, becausemainrequires zero approving reviews and an approval cannot satisfy a status check. Reason (b) for the App-opened release PR is now live.docs/decisions/1182-required-checks.md, its index row, and one rule paragraph in.github/AGENTS.md. They cover:if:can skip needs the same summary job;integration_idpin does and does not prove;After merge
Add
Image build + smoke test(integration_id 15368) to ruleset 24852475. Requiring it before this merges would block every PR whose base lacks the job.Verification
mainrequires zero approving reviews,release/v1.0.xrequires no checks, and the default workflow token permission is read. No workflow grantsstatuses: write.node --test .github/scripts/: 102 passed. Tracked-file guards:Documentationtests 20 passed,SchemaDocsTestsandSolutionTestProjectSplitTests5 passed. actionlint is not installed here.Image build + smoke testas a single passing check.