Skip to content

docs/images/dashboard.png is generated by the screenshot spec but never committed #663

Closed

Description

@mforce

tools/simulation/ui/specs-screenshots/screenshots.spec.ts captures four images. Only three are tracked:

$ git ls-files docs/images/
docs/images/daily-entry.png
docs/images/reports.png
docs/images/sales.png

Running npm run screenshots therefore always leaves docs/images/dashboard.png as an untracked file, which reads as an accidental artefact rather than a deliberate omission — and git checkout -- docs/images/ does not clean it up, so it survives a tidy-up that looks complete.

Pre-existing; noticed while capturing before/after comparisons for #661, not introduced by it.

Either commit it beside the other three, or exclude it from the capture spec. The staleness contract in specs-screenshots/screenshots.spec.ts should say which.

Activity

  1. mforce commented on Sep 2, 2026

    @mforce
    OwnerAuthor

    Shipped in #665, merged as 930ea308. docs/images/dashboard.png is now tracked alongside the other three, and tools/simulation/ui/README.md's image count matches what ships.

    The staleness-contract comment in specs-screenshots/screenshots.spec.ts was updated to say all four captures are committed, so the next reader is not left wondering whether the fourth was a deliberate omission — which is exactly the ambiguity this issue was filed about.

  2. added a commit that references this issue on Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions