This repository was archived by the owner on Nov 10, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 10, 2023. It is now read-only.
GCC Toolchain Path Incorrect Post R22 NDK #2700
Description
After R22 of the NDK, the NDK is clang only for build it seems? Per android/ndk#1375 this means that the GCC toolchains that are attempting to be found no longer are (specifically at https://github.com/facebook/buck/blob/5444652af489563ddaf595a634341dd14fd41399/src/com/facebook/buck/android/toolchain/ndk/impl/NdkCxxPlatforms.java#L1250-L1253 this causes error using newer toolchains than R22).
Activity
[-]Sysroot Path Incorrect Post NDK R19[/-][+]GCC Toolchain Path Incorrect Post R22 NDK[/+]GEMISIS commentedon May 7, 2022
Looks like my original bug was an issue with my paths, but there is still an issue in that GCC related tools are being linked in the toolchain, which are no longer included with the NDK after R22.
GEMISIS commentedon May 8, 2022
Actually, looks at this again, it may also be that it's failing before getting to what my original comment was discussing?
Per android/ndk#1407, the sysroot path for NDK is now contained in /toolchains/llvm/prebuilt//sysroot instead of the top level directory. This means that buck is looking in the wrong spot for the sysroot directory at https://github.com/facebook/buck/blob/5444652af489563ddaf595a634341dd14fd41399/src/com/facebook/buck/android/toolchain/ndk/impl/NdkCxxPlatforms.java#L1209
It seems that NDK support may not have been kept up to date?
GEMISIS commentedon May 8, 2022
Yeah, it looks like in the NdkCxxPlatforms.java file, there's a lot of updates that need to happen for more recent versions of the NDK, as everything after R19 is completely broken. The latest I've managed to get building on Windows is NDK version 19.2.5345600.
LegNeato commentedon May 10, 2022
#2685