Repository navigation
Fix CMake toolchain file for clang-cl with - args - #16343
Open
TGillingham wants to merge 1 commit into
Open
TGillingham wants to merge 1 commit into
TGillingham wants to merge 1 commit into
Conversation
The target for clang-cl is determined in part by passing args like `-m32`, which don't follow the msvc argument syntax. This caused problems with the generated CMake toolchain file when attempting a cross compilation with clang-cl: the `-m32` argument was not detected as a command line option, so clang-cl was set as the `CMAKE_C_COMPILER_LAUNCHER`, and `-m32` was set as the `CMAKE_C_COMPILER`. Detect when clang-cl is in use and consider both `/` and `-` as command line option prefixes. With this change, a binary such as `['clang-cl', '-m32']` will generate CMake toolchain file that uses `clang-cl` instead of `-m32` as the compiler.
TGillingham
marked this pull request as ready for review
November 6, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target for clang-cl is determined in part by passing args like
-m32, which don't follow the msvc argument syntax.This caused problems with the generated CMake toolchain file when attempting a cross compilation with clang-cl: the
-m32argument was not detected as a command line option, so clang-cl was set as theCMAKE_C_COMPILER_LAUNCHER, and-m32was set as theCMAKE_C_COMPILER.Detect when clang-cl is in use and consider both
/and-as command line option prefixes. With this change, a binary such as['clang-cl', '-m32']will generate CMake toolchain file that usesclang-clinstead of-m32as the compiler.