Repository navigation
Add EXT_texture_norm16 spec - #2147
Conversation
|
(side note: the CI error message is very unhelpful and there was no error locally). |
chrisdavidmills
left a comment
There was a problem hiding this comment.
This looks good. I'll merge this now.
|
Ah wait, I can't because the commit is not signed. @peterbe is this because @Elchi3 needs to set up signature verification, a la https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/about-commit-signature-verification ? |
|
I guess I ought to do that too, in that case |
|
I had signed commits set up previously but forgot to do it again after I pruned my laptop. Grr. The Yari repo has no contributing.md nor seem to mention this anywhere, fwiw. |
|
I used to do it via SSH keys, but it looks lke GH doesn't support those any more? I'll go learn about GPG ;-) |
|
@Elchi3 So good to "see" you my friend! I'll merge this for now. |
|
Thank you, Ryan! ❤️ Looking forward to talking more :) |
|
For now, the mdn/yari repo requires signed commits but the mdn/content repo does not. Ideally, we should require it everywhere but the assumption is that there'll be a lot more people who come to mdn/content and they might not have it set up. Clearly, this is happening. I think we should consider it a warning for contributors. A manual warning (ie. no GitHub PR bot). |
Adds the spec for mdn/content#187