[worktrunk-bot]

Follow-up to #3740, which fixed the same class of gap on GitLab and Azure DevOps. aggregate_github_checks reads three fields, each drawn from a different GitHub enum, and each list was missing values — with the same consequence in every case: a check that is not terminal reads as terminal, so the row settles on a verdict before CI has one.

CheckStatusState was missing WAITING and REQUESTED. The in-flight gate matched in_progress | queued | pending, so neither reached has_running. WAITING is where a deployment-protection rule or a required reviewer parks a run — it can sit there for hours — and with every other check green the aggregate returned Passed. wt list --full showed a green CI cell for a PR that was blocked on an approval gate and had run nothing.

StatusState::EXPECTED was matched against the wrong field. "expected" sat in the status list, where it can never appear (CheckStatusState has no EXPECTED), while the state branch tested s == "pending" only. EXPECTED is a required context branch protection knows about but nobody has posted yet — non-terminal, and it now joins pending there. The stray "expected" under status is left in place, as is the equally cross-field "error" under conclusion: those combinations don't occur, but tolerating them costs nothing and fails safe. The docstring records that this is deliberate rather than an oversight.

CheckConclusionState::STARTUP_FAILURE contributed nothing. A run that failed to start fell through the failure list to the ignore arm, so it counted neither way — a PR whose only non-green check failed at startup rendered Passed. It joins the failure list. STALE stays ignored alongside SKIPPED and NEUTRAL, and the docstring now says why: GitHub marks a result stale when it no longer reflects the commit, so it isn't a verdict on this commit either way.

Verification

Enum values confirmed by GraphQL introspection against the live schema rather than from docs:

$ gh api graphql -f query='{ __type(name: "CheckStatusState") { enumValues { name } } }'
REQUESTED QUEUED IN_PROGRESS COMPLETED WAITING PENDING

$ gh api graphql -f query='{ __type(name: "StatusState") { enumValues { name } } }'
EXPECTED ERROR FAILURE PENDING SUCCESS

$ gh api graphql -f query='{ __type(name: "CheckConclusionState") { enumValues { name } } }'
ACTION_REQUIRED TIMED_OUT CANCELLED FAILURE SUCCESS NEUTRAL SKIPPED STARTUP_FAILURE STALE

The three fixes were each reverted independently against the extended test to confirm the test catches them and that none is carried by another:

Reverted	Failure
waiting / requested	assertion failed: status=waiting — left: Passed, right: Running
expected in the state branch	left: Passed, right: Running
startup_failure	assertion failed: conclusion=startup_failure — left: Passed, right: Failed

Each reverted gap produces Passed where the correct answer is Running or Failed, which is the shape of the user-visible bug: a green cell on a PR that has not passed.

cargo test --bins aggregate_github_checks, cargo clippy --bins --all-features, and cargo fmt all pass. Pure classification change — no forge call and no output-format impact, so no snapshots move.