Repository navigation
Conversation
# Conflicts: # src/commands/picker/mod.rs # src/testing/mod.rs
worktrunk-bot
approved these changes
Jul 30, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the first test-simplification tranche by converging the remaining suite around distinct semantic and pragmatic contracts rather than raw case count. The branch removes false-confidence tests, invalid setup variants, repetitive snapshots, and expensive PTY overlap while strengthening the retained route, precondition, and interaction proofs.
What changed
Reviewer map
tests/integration_tests/ci_status.rsandsrc/commands/list/ci_status/: provider semantics and route coverage.tests/integration_tests/switch_picker.rs,src/commands/picker/, andsrc/testing/: retained PTY contracts, causal mocks, and fixture design.tests/integration_tests/config_show.rs,src/config/deprecation.rs,src/config/expansion.rs, and worktree type/resolve tests: direct-boundary consolidation.tests/CLAUDE.md: the testing rules extracted from the false-confidence cases found during the survey.The measured loop removed 98 tests, 65 snapshots, and 23 picker PTYs. Controlled warm Nextest execution improved from a 79.593-second mean to 72.574 seconds (8.8%), while comparable production-line coverage moved from 97.32% to 97.23%. The tracked PR diff is a net deletion of more than 5,700 lines.
Validation
cargo run -- hook pre-merge --yesafter syncing currentmain: 4,468 passed, one configured skip; docs, doctests, clippy, formatting, policy checks, and snapshots green.task coverageon the completed change before the base sync: 4,465 passed, one configured skip; 97.23% comparable production-line coverage.