Repository navigation
Conversation
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #859
Stacked on #855.
Change
--jscode that runs once per file now runs at the first match of the file. A file with no match does not run it. Before, it ran at the start of every file, and the value was then not used for a file with no match. So code with a side effect, like printing or writing a file, ran for files it did not change, and an error in the code was told for the first file, also when it had no match.The help and the README say: "For speed, the code runs once per file, at its first match, unless it names the match, a group,
$mor$M. A file without a match does not run the code."For the release note of v8: code with a side effect now only runs for a file with a match.
Tests
test/fix/859.test.jsis new, and 2 of its 3 tests fail without the fix: a file with no match does not run the code, and an error is told for the first file with a match. The third checks that a file with two matches still runs the code once.yarn test-cipasses.