You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With ruby 1.8.7 (2012-10-12 patchlevel 371) [x86_64-linux] I'm getting the following test failure:
..... the next will fail .....
$a.rot90
test/testreverse.rb:5:in `px': ./lib/narray_ext.rb:267:in `rot90': must be >= 2 dimensional array (RuntimeError)
from (eval):1:in `px'
from test/testreverse.rb:26:in `eval'
from test/testreverse.rb:5:in `px'
from test/testreverse.rb:26
So you are saying that the test suite should crash and have an exit code of 1? That makes it more difficult to use a CI system which always expects a clean run. You can't catch this exception and test it?
Aha, now I see what is going on. We already comment out the other similar tests for Gentoo's test phase, but this one has different wording. Ok, I'll handle this on the Gentoo side.
Activity
masa16 commentedon May 9, 2013
See the first line you copied.
graaff commentedon May 9, 2013
So you are saying that the test suite should crash and have an exit code of 1? That makes it more difficult to use a CI system which always expects a clean run. You can't catch this exception and test it?
masa16 commentedon May 9, 2013
This is a legacy test code before unit test became popular. Now it should be rewritten as Spec...
graaff commentedon May 9, 2013
Aha, now I see what is going on. We already comment out the other similar tests for Gentoo's test phase, but this one has different wording. Ok, I'll handle this on the Gentoo side.
graaff commentedon May 9, 2013
Now that I'm past this problem I'm also seeing
masa16 commentedon May 9, 2013
Fixed. c56dc59
Thank you.