Skip to content

Replace image with gdk-pixbuf - #319

Open
linkmauve wants to merge 1 commit into
marin-m:mainfrom
linkmauve:no-image
Open

linkmauve wants to merge 1 commit into
marin-m:mainfrom
linkmauve:no-image

Conversation

@linkmauve

@linkmauve linkmauve commented May 15, 2026 •

Copy link
Copy Markdown
Contributor

This reverts commit 62aee2f.

On the other hand, this allows to remove 10 crates, and significantly reduce compilation time, while also removing 220 KiB from the stripped binary.

Note: this is untested, I don’t have any SNI setup.

This reverts commit 62aee2f.

On the other hand, this allows to remove 10 crates, and significantly
reduce compilation time, while also removing 220 KiB from the stripped
binary.
@marin-m

marin-m commented May 15, 2026 •

Copy link
Copy Markdown
Owner

Re,

The change doesn't work, the resource doesn't load:

$ cargo run --release
    Finished `release` profile [optimized] target(s) in 0.23s
     Running `target/release/songrec`

thread 'main' (2158319) panicked at src/plugins/ksni.rs:17:90:
called `Result::unwrap()` on an `Err` value: Error { domain: g-resource-error-quark, code: 0, message: "La ressource dans «\u{a0}re.fossplant.songrec-symbolic.png\u{a0}» n’existe pas" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Also if I understand well the documentation read_pixel_bytes is not meant to return data with any regular structure, it's an opaque blob, while KSNI expects ARGB8.

Also Cargo.lock is not meant to be edited at hand as the results are unpredictable, it is modified automatically by cargo when you test your change through building.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants