Skip to content

Python 3.14 annotations support fix - #5

Closed
manzt wants to merge 1 commit into
push-yxusyvtszmvsfrom
push-nnskpoplqxvw
Closed

manzt wants to merge 1 commit into
push-yxusyvtszmvsfrom
push-nnskpoplqxvw

Conversation

@manzt

@manzt manzt commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator

Original patch in msgspec#852.

@ionelmc

ionelmc commented Oct 15, 2025

Copy link
Copy Markdown

@manzt I would like to suggest that renaming everything to msgspec_m seems counterproductive if the goal of this fork is to be a drop-in, bugfix-only project. Unless you want to do more than just bugfixes. If there's a choice to add from __future__ import annotations all over the place or replace all the imports in one's project I think people will find the former simpler.

@manzt

manzt commented Oct 15, 2025

Copy link
Copy Markdown
Collaborator Author

@ionelmc thanks for the suggestion. I've made #7 reverting the rename (and providing some rationale for why I chose to rename in the first place).

@ionelmc

ionelmc commented Oct 15, 2025

Copy link
Copy Markdown

I kinda understand where that is coming from - I guess you have a dependency that depends on msgspec, and your main project or other deps want to depend on msgspec-m. Sadly there's no pretty solution, and Obsoletes-Dist/Provides-Dist metadata is not supported in any tool (https://packaging.python.org/en/latest/specifications/core-metadata/#obsoletes-dist-multiple-use) but having msgspec and msgspec_m trying to interoperate in a single codebase ain't it (is it even possible? wouldn't all the utilities be broken).

The way I see it the path of least friction is to just get dependencies to also depend on msgspec-m.

@ofek

ofek commented Oct 19, 2025

Copy link
Copy Markdown

I became a co-maintainer and will try to merge everything that is required for supporting 3.14 in the next few days.

@manzt

manzt commented Oct 19, 2025

Copy link
Copy Markdown
Collaborator Author

fantastic news, thank you for shepherding @ofek

@ofek

ofek commented Nov 24, 2025

Copy link
Copy Markdown

msgspec support for 3.14 has been released https://github.com/jcrist/msgspec/releases/tag/0.20.0

Subsequent releases will be much faster with the new enhancements to the developer experience and performance profiling 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants