On `sql-formatter`

[qzdl]

Description

SQL formatting in marimo feels a bit bolted-on:

• SQL is not formatted via Format All or Cell > Format,
• No user-facing options exposed (ALL CAPS ALL THE TIME),
• fully-clientside JS library, rather than server-side (LSP &| tree-sitter).

also, essentially deprecated lib:

The development of this formatter is currently in maintenance mode. Bugs will get fixed if feasible, but new features will likely not be added.

• https://www.npmjs.com/package/sql-formatter

Are you willing to submit a PR? (You must receive approval from the team before submitting a PR.)

• Yes

Alternatives

using --watch with watchexec & custom formatter; main issue is being post-hoc, amplifying writes, and re-triggering execution.

(& in comparison, we are really spoiled with the first-party ruff integration)

Additional context

No response

[mscolnick]

SQL is not formatted via Format All or Cell > Format,

This is intentional. The SQL formatter is VERY opinionated with spacing and newlines (whereas ruff defaults are widely accepted). And it would be a bad experience to opt-in users.

No user-facing options exposed (ALL CAPS ALL THE TIME),

We can look into making it more configurable, without overfitting to sql-formatter.

fully-clientside JS library, rather than server-side (LSP &| tree-sitter).

This means it works seamlessly in WebAssembly, so there are tradeoffs.

essentially deprecated lib

I think maintenance mode is quite reasonable for a formatter. It makes sense at some point it is feature-complete.

---

All this being said, we are open to making incremental improvements. If you have proposals that we can discuss first, we are open to contributions.