Repository navigation
Conversation
alexander-kulikovskii
approved these changes
Aug 11, 2022
pengdev
reviewed
Aug 11, 2022
Chaoba
approved these changes
Aug 11, 2022
pengdev
approved these changes
Aug 11, 2022
kiryldz
force-pushed
the
MAPSAND-368-gestures-dont-work-as-expected-in-map-surface-activity
branch
from
August 11, 2022 08:45
14d900d to
ff9be72
Compare
kiryldz
deleted the
MAPSAND-368-gestures-dont-work-as-expected-in-map-surface-activity
branch
August 11, 2022 09:19
mapbox-github-ci-writer-public-1 Bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
Co-authored-by: root <root@4bc29afcb2c1>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
When implementing MapSurface (e.g. for Android Auto) it is regular practice to overload just
surfaceCreated,surfaceChangedandsurfaceDestroyedmethods. However in that case we're missingMapControllable.onSizeChangedcall that actually notifies all the plugins.That will lead as an example to incorrect map shove gesture as center focal point will always be (0, 0). Now
surfaceChangedcall will also callMapControllable.onSizeChangedunder the hood.User impact (optional)
Pull request checklist:
@JvmOverloads,@file:JvmName, etc).make update-apito update generated api files, if there's public API changes, otherwise theverify-api-*CI steps might fail.check changelogCI step will fail.v10.[version]release branch fix / enhancement, merge it tomainfirstly and then port tov10.[version]release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.