Repository navigation
Test that the root and scaffold Dependabot ignore lists match - #122
Merged
Merged
Conversation
The root config scans scaffolds/csharp-api in place and the scaffold's own config ships to new projects. I kept the two ignore lists in sync by hand, so a rule added to one could be missed in the other. Also reword the SQLitePCLRaw pin comment in App.Data.csproj. It said EF Core requires the pinned version itself, but Microsoft.EntityFrameworkCore.Sqlite 10.0.15 brings in 2.1.13 through its bundle and the pin is 2.1.14.
A blank line inside both lists ended the read early, so rules after it were never compared. A trailing comment on a rule line counted as part of the rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two leftovers from the review of #121.
What changed
.github/dependabot.ymlscansscaffolds/csharp-apiin place, and the scaffold's owndependabot.ymlships to new projects. I kept the two NuGetignorelists in sync by hand.tools/csharp-api.test.mjsnow reads both lists and fails when they differ, or when it finds no rules in the root file.App.Data.csprojsaidMicrosoft.EntityFrameworkCore.Sqlite"now requires this version itself". 10.0.15 brings inSQLitePCLRaw.lib.e_sqlite32.1.13 through its bundle (read off the two nuspec files in the NuGet cache) and the pin is 2.1.14. The comment now says the pin is a floor at or above what EF Core brings in, with no version number that can go stale.Verified
dotnet build App.Data/App.Data.csproj: 0 warnings, 0 errors.ignore:gone from both files, and a blank or spaces-only line inside both lists with a different rule after it. It stays green with a trailing comment on a rule line.Review
/code-review high, two rounds. Four findings fixed (blank line, spaces-only line and trailing comment in the reader, one inaccurate comment). Two stay:ignoreRulesreturns the raw rule lines, and each rule is a pair of lines, so the same rules in a different order go red. The failure prints both lists, and a red here never hides a real difference.7d90f98). Whether 2.1.13 still needs a floor above it, or the pin can go, is my call to make and outside this change.