Skip to content

Test that the root and scaffold Dependabot ignore lists match - #122

Merged
malinfossum merged 3 commits into
mainfrom
chore/sqlite-pin-comment-ignore-parity
Nov 19, 2026
Merged

malinfossum merged 3 commits into
mainfrom
chore/sqlite-pin-comment-ignore-parity

Conversation

@malinfossum

Copy link
Copy Markdown
Owner

Two leftovers from the review of #121.

What changed

  • Ignore-list test. The root .github/dependabot.yml scans scaffolds/csharp-api in place, and the scaffold's own dependabot.yml ships to new projects. I kept the two NuGet ignore lists in sync by hand. tools/csharp-api.test.mjs now reads both lists and fails when they differ, or when it finds no rules in the root file.
  • Pin comment. App.Data.csproj said Microsoft.EntityFrameworkCore.Sqlite "now requires this version itself". 10.0.15 brings in SQLitePCLRaw.lib.e_sqlite3 2.1.13 through its bundle (read off the two nuspec files in the NuGet cache) and the pin is 2.1.14. The comment now says the pin is a floor at or above what EF Core brings in, with no version number that can go stale.

Verified

  • Root suite: 222 of 222 pass.
  • dotnet build App.Data/App.Data.csproj: 0 warnings, 0 errors.
  • The new test goes red on each of these temporary edits: a rule missing from the scaffold, ignore: gone from both files, and a blank or spaces-only line inside both lists with a different rule after it. It stays green with a trailing comment on a rule line.

Review

/code-review high, two rounds. Four findings fixed (blank line, spaces-only line and trailing comment in the reader, one inaccurate comment). Two stay:

  • The comparison is order-sensitive. ignoreRules returns the raw rule lines, and each rule is a pair of lines, so the same rules in a different order go red. The failure prints both lists, and a red here never hides a real difference.
  • The pin comment gives no reason or removal condition. The pin began as an advisory fix (7d90f98). Whether 2.1.13 still needs a floor above it, or the pin can go, is my call to make and outside this change.

The root config scans scaffolds/csharp-api in place and the scaffold's own
config ships to new projects. I kept the two ignore lists in sync by hand, so
a rule added to one could be missed in the other.

Also reword the SQLitePCLRaw pin comment in App.Data.csproj. It said EF Core
requires the pinned version itself, but Microsoft.EntityFrameworkCore.Sqlite
10.0.15 brings in 2.1.13 through its bundle and the pin is 2.1.14.
A blank line inside both lists ended the read early, so rules after it
were never compared. A trailing comment on a rule line counted as part
of the rule.
@malinfossum
malinfossum merged commit 5ba6f87 into main Nov 19, 2026
14 checks passed
@malinfossum
malinfossum deleted the chore/sqlite-pin-comment-ignore-parity branch November 19, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant