Repository navigation
Stop Dependabot from proposing Microsoft.OpenApi 3.x - #116
Merged
Merged
Conversation
Microsoft.AspNetCore.OpenApi 10.x requires Microsoft.OpenApi below 3.0.0, so every 3.x bump fails restore with NU1608. The ignore comment on the PR never registered, so the rule lives in dependabot.yml where I can see it.
A project copied from the scaffold has the same explicit pin and would get the same failing 3.x PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One
ignorerule, in two Dependabot configs: Dependabot skips major bumps ofMicrosoft.OpenApi..github/dependabot.yml: covers the nuget block forscaffolds/csharp-apiin this repo.scaffolds/csharp-api/.github/dependabot.yml: the config a project copied from the scaffold starts with. It has the same explicit pin, so it would get the same failing PR.Why
Microsoft.AspNetCore.OpenApi 10.0.15requiresMicrosoft.OpenApi (>= 2.13.0 && < 3.0.0). The 3.11.1 bump in #109 fails restore with NU1608 on bothApp.ApiandApp.Tests, and it will keep failing for every 3.x release while the scaffold is on .NET 10.I posted
@dependabot ignore this major versionon #109 twice and Dependabot never answered, so the ignore lives in the config file instead, where it is visible and reviewable. Minor and patch bumps ofMicrosoft.OpenApistill arrive in thenuget-minor-patchgroup.Verified
ward / dotnetjob on Bump Microsoft.OpenApi from 2.13.1 to 3.11.1 #109..github/dependabot.ymlcheck passed on the root file. The scaffold file carries the same five lines at the same indent; nothing validates it until a project uses it.Review
/code-review high, two rounds, no bugs. Two notes fixed: the comment now namesMicrosoft.AspNetCore.OpenApias the package to recheck, and the scaffold's own config carries the rule. One stays, one was a false alarm:Microsoft.OpenApiis an explicit pin inApp.Api/App.Api.csproj: when the framework package raises its floor past the pin, restore fails on the downgrade and points straight at it. The comment on the rule names the recheck trigger.planDependabotin Ward'stools/apply.mjskeeps an existingdependabot.ymlwhenever its ecosystem blocks are present and never overwrites one.