Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Owner
Author
|
Verified commit |
github-actions
Bot
deleted the
codex/propose-fix-for-routing-analytics-crash
branch
November 5, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
row_jsonthrough an attempt-aware pricing helper that assumedattemptswas a real array, which could throw aTypeErrorfor malformed persisted rows.Description
normalizePersistedUsageRowand applying it inparseEntryso decodedrow_jsonis validated/normalized before any pricing logic runs insuccessCostUsd(src/routing/analytics.ts).attempts: { length: 1 }) and adjust expectations so analytics completes and counts the row (tests/routing/routing-analytics.test.ts).src/routing/analytics.tsandtests/routing/routing-analytics.test.tsonly and preserve existing analytics semantics for well-formed rows while dropping or repairing unsafe fields from malformed rows.Testing
bun test tests/routing/routing-analytics.test.ts, which passed (12 tests, 0 failures).bun x tsc --noEmit, which passed.bun run test:changedbut it could not run in the current environment because the localbunruntime available to the test harness is older than the repository's required test runner (bun1.4.3).Codex Task