Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{YY}currently usesDate.getYear(), which returns the year minus 1900. For many earlier dates the negative value is sliced incorrectly: year 1801 formats as99, and year 1899 formats as-1, instead of01and99.Use
getFullYear()and let the existing two-character formatter select the year suffix. Modern dates and custom formatter overrides retain their behavior.Validation:
npm testpasses all 29 assertions on local Node 22 and every CI runtime: Node 6, 12 and 18.git diff --checkpasses.AI assistance: Codex assisted with discovery, implementation and validation. Tests cover nonnegative calendar years; formatting of dates before the common era is unchanged.