Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the requested provenance behavior and includes focused coverage for state transitions and UI edge cases.
Review effort: Balanced
Findings: None
What changed in this PR
Adds accurate AMM registry provenance and refresh status to Settings while preserving loaded snapshots during pending or failed requests.
Changes:
- Exposes registry request, snapshot, override, loading, and error status through QtRO.
- Adds a responsive, scrollable Settings status UI.
- Adds C++ and QML coverage for provenance, caching, failures, and layout.
| File | Description |
|---|---|
apps/amm/CMakeLists.txt |
Registers C++ tests. |
apps/amm/qml/chrome/SettingsModal.qml |
Displays registry provenance and status. |
apps/amm/src/AmmUiBackend.cpp |
Publishes loader status through QtRO. |
apps/amm/src/AmmUiBackend.rep |
Adds the registry status property. |
apps/amm/src/RegistryLoader.cpp |
Tracks request and snapshot state separately. |
apps/amm/src/RegistryLoader.h |
Defines the status API and state. |
apps/amm/tests/cpp/CMakeLists.txt |
Configures registry status tests. |
apps/amm/tests/cpp/RegistryStatusTest.cpp |
Tests loader status behavior. |
apps/amm/tests/qml/tst_SettingsModal.qml |
Tests Settings presentation and responsiveness. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
3esmit
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings now identifies the configured registry URL separately from the source supplying the current token and pool lists. A QtRO status map exposes the effective request URL, environment override, published snapshot source and origin, and refresh progress or failure.
When registry B is requested while registry A remains loaded, Settings continues to identify A as the data source. A cached snapshot is labeled with its validated cache URL. Local configuration and empty network lists receive explicit explanations. The modal scrolls within short windows and displays long URLs as plain text.
Status-only changes use a separate loader signal, so starting or failing a request does not bump
registryRevisionor re-publish AMM program/config IDs. The existing source precedence and cache acceptance rules remain intact.Validation
amm_registry_statusCTest passes with Qt 6.11.0, covering local and URL overrides, pending and failed refreshes, matching and mismatched cache origins, invalid/empty registry documents, and superseded requests.repcgenerates the updated source contract successfully.Fixes #407 https://github.com/logos-co/audit-reports/issues/176