Fix User.stop() crash when greenlet hasn't started yet - #3506
Merged
cyberw merged 2 commits intoSep 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
User.stop()for users whose greenlet has not startedSummary
Fixes
User.stop(force=False)raising an exception when a user's greenlet has been spawned but has not started running yet (_state is None).This can occur during spawning when a test is stopped with a non-zero
--stop-timeout.Fix
Treat
_state is Nonethe same asLOCUST_STATE_WAITINGand kill the greenlet immediately:A user in this state has not started running, so there is no task or
on_starthook to wait for.Testing
Added
test_stop_user_before_greenlet_startsto reproduce the issue.