Repository navigation
wrap.py: Fix Python 3.15 compatibility issue with re.Scanner - #773
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the issue but not tested with Python 3.15 yet.
Here's what Claude says:
Fixed Python 3.15 compatibility issue with
re.Scannerby replacing capturing groups with non-capturing groups:Changes made:
OuterCommentLexer (lines 306-309): Changed
(.|[\r\n]) to (?:.|[\r\n])in the multiline and single-line comment patterns, and({(?!{)...})to(?:{(?!{)...})in the text pattern.InnerLexer (lines 313-318): Replaced the complex pattern with backreferences
(["\'])?((?:(?!\1)[^\\]|\\.)*)\1with two simpler patterns:r'"(?:[^"\\]|\\.)*"'for double-quoted stringsr"'(?:[^'\\]|\\.)*'"for single-quoted stringsThis avoids the backreference \1 which required a capturing group.
Why these changes work:
The quoted_id callback function at line 323 will still work correctly because it processes the entire matched token string (with quotes) using re.sub() to strip the quotes.