i18n: Feat/add zig wasm - #1025
Conversation
Deploying livecodes with
|
| Latest commit: |
e2b3717
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09c1afe5.livecodes.pages.dev |
| Branch Preview URL: | https://i18n-seth0x41-feat-add-zig-w.livecodes.pages.dev |
✅ Deploy Preview for livecodes ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
The Hindi zigWasm.link string pulled from Lokalise has translated placeholder tags and will render broken after merge — the Hindi Zig tooltip loses all links and the "Load starter template" button (Hindi previously fell back to the working English tooltip, so this PR regresses it). One more Lokalise string (Bengali) has corrupted link text, and the "update source texts" commit incidentally modified a non-i18n file. Details are in the inline comments.
Reviewed changes
- Zig (Wasm) — all non-English locales: Adds the
zigWasmlanguage-info keys (desc/link/name) and thetemplates.starter.zig-wasmstarter-template key to all 17 non-enlocales (language-info.*andtranslation.*), pulled from Lokalise. Verified thelinkplaceholder sequences (<tag-1>..<tag-10>) against theensource in all locales except the two flagged inline. - Unrelated
storybook/solid/src/solid.tschange: The "i18n: update source texts" commit stripped an// eslint-disable-next-line import/ordercomment in a non-i18n file, which is unrelated to this translation pull.
DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏
| }, | ||
| zigWasm: { | ||
| desc: 'वेबअसेंबली पर चल रहा ज़िग कंपाइलर।', | ||
| link: '<टैग-1> <टैग-2>ज़िग वेबसाइट</टैग-2> </टैग-1> <टैग-3> <टैग-4>ज़िग भाषा दस्तावेज़ीकरण</टैग-4> </टैग-3> <टैग-5> <टैग-6>वाई मिनटों में एक्स सीखें, जहां एक्स=ज़िग</टैग-6> </टैग-5> <टैग-7> <टैग-8>लाइवकोड दस्तावेज़ीकरण</टैग-8> </टैग-7> <टैग-9> <टैग-10>स्टार्टर टेम्पलेट लोड करें</टैग-10> </टैग-9>', |
There was a problem hiding this comment.
The <टैग-1>..<टैग-10> placeholder tags should not be translated. unabstractifyHTML in src/livecodes/i18n/utils.ts only maps ASCII-numbered tags (/<(\/?)(\d+)([^>]*)>/g), so none of these match: the Hindi Zig tooltip will render the literal <टैग-1> <टैग-2>… markup and drop all links plus the "Load starter template" button (found via a[data-template]). Since fallbackLng: 'en' only applies to missing keys, this is a regression from the working English fallback the Hindi locale had before this PR. This is a known recurring Lokalise corruption — the .lokalise.json carries the same string, so fix it in Lokalise too or the next auto-pull will re-introduce it.
| }, | ||
| zigWasm: { | ||
| desc: 'জিগ কম্পাইলার ওয়েবঅ্যাসেম্বলিতে চলছে।', | ||
| link: '<1> <2>Zig ওয়েবসাইট</2> </1> <3> <4>জিগ ল্যাঙ্গুয়েজ ডকুমেন্টেশন</4> </3> <5> <6>Y মিনিটে X শিখুন, যেখানে X=Zig</6> </5> <7> <8>Live-8>Live-Contation</8> </7> <9> <10>স্টার্টার টেমপ্লেট লোড করুন</10> </9>', |
There was a problem hiding this comment.
Tags 7/8 are corrupted: the LiveCodes docs link label renders as Live-8>Live-Contation (the stray 8> becomes literal text in the tooltip). Same fix location as the hi finding — correct the string here and in bn/language-info.lokalise.json.
| import type { Component, JSX } from 'solid-js'; | ||
| import { createPlayground } from 'livecodes'; | ||
| // eslint-disable-next-line import/order | ||
There was a problem hiding this comment.
Unrelated to this translation pull: the "i18n: update source texts" commit (0425cec) replaced the // eslint-disable-next-line import/order comment with a whitespace-only line, which prettier --check flags. Please revert this hunk entirely.
|
@pullfrog fix all |
|
Fixed all broken What was wrong — two locales came back from Lokalise with corrupted
Fixes — restored correct Verification — Note: since Task list (7/7 completed)
|
|
@pullfrog |
|
Completed the follow-up from the earlier (cancelled) run, which had already restored 1. Swept all i18n files for placeholder-tag corruption (not just zig)
Each 2. README badge Both changes are in commit
|
Sweep all non-English language-info locales for mangled `tag-N` link placeholders (translated tag words, mispaired/unclosed tags, missing entries, crammed text) and fix the corrupted `link` strings, matching each locale's sequence to the English source: - go.link (12 locales): restore missing "LiveCodes Documentation" entry (tags 9-10) and move starter-template text to tags 11-12 - java.link (12 locales): restore missing "LiveCodes Documentation" entry (tags 7-8) and move starter-template text to tags 9-10; rebuild the badly mangled hi/ja/zh-CN/ur strings - csharpWasm.link (hi) and jinja.link (hi, ur): restore translated/non-ASCII placeholder words and stray text to valid ASCII tag sequences Regenerate language-info.ts for the touched locales via the canonical i18n pipeline. Also bump the README languages badge from 100 to 101 (Zig wasm).
|
1 participant
What type of PR is this? (check all applicable)
Description
i18n Actions:
.i18n-update-pullLocalization pulled from Lokalise.
i18n/Seth0x41/feat/add-zig-wasmRelated Tickets & Documents