libnvme: group discovery decision state and log it per entry - #3813
Merged
igaw merged 2 commits intoAug 12, 2026
Merged
Conversation
added 2 commits
August 11, 2026 10:39
Each Discovery Log Page entry's controller, connect decision, disconnect decision, and already-connected state were separate locals and out-params threaded through dc_should_connect() and nvmf_connect_disc_entry(). Bundle them into struct dc_decision. Add dc_log_decision(), logged at LIBNVME_LOG_DEBUG (-vv), covering every entry including early skips (duplicate info, transport mismatch, already connected) and the primary's own self-entry decision, so a customer bug report captured with -vv shows what was decided for every entry and why. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
nvme_discovery_log() returns a negative errno on failure, but the value was passed directly to libnvme_strerror() which requires a positive errno. Same defect as 36e1ab9 fixed in nbft_discovery(). Signed-off-by: Martin Belanger <martin.belanger@dell.com>
martin-belanger
force-pushed
the
fix-persistent-dc-disconnect-logging
branch
from
August 11, 2026 14:41
1570f71 to
19d85e2
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each Discovery Log Page entry's controller, connect decision, disconnect decision, and already-connected state were separate locals and out-params threaded through dc_should_connect() and nvmf_connect_disc_entry(). Bundle them into struct dc_decision.
Add dc_log_decision(), logged at LIBNVME_LOG_DEBUG (-vv), covering every entry including early skips (duplicate info, transport mismatch, already connected) and the primary's own self-entry decision, so a customer bug report captured with -vv shows what was decided for every entry and why.