[lidge-jun]

Summary

The dev lane=all run 40756291846 failed windows 1/9 on Windows Child HTTP handles success without proxying or following redirects (child exit 1 instead of 0). Every scenario in that loop passed a 250ms deadline to windowsChildHttpArgv, so the success case had to finish a cold PowerShell HttpWebRequest round trip within 250ms on a hosted runner. Production never uses such a budget: remoteChildHttpArgv defaults to LINK_RELAY_VERIFY_MS (15s).

Only the stalled body scenario exercises the deadline, so it keeps 250ms; the other scenarios get 10s. Assertions are unchanged, so redirects, proxies, oversize and invalid UTF-8 are still refused exactly as before. Test-only change.

Verification

• Not reproducible locally: the file alone (3x) and the exact CI batch in order (3x) all passed at 53a98e9f; the hosted run discarded the child's stderr, so the deadline explanation is inferred from the 250ms budget, the 1.2s hosted duration versus ~0.5s in passing runs, and the production default.
• Windows x64, Bun 1.4.4, OCX_TEST_NO_QUEUE=1: tests/clients/link-ssh-argv-discovery.test.ts 13 pass / 18 skip (POSIX-only) / 0 fail; the stalled-body case still fails closed on the deadline.

NOT RUN: hosted Windows (next lane=all dev batch), full suite.

Checklist

• Scope stays focused and avoids unrelated cleanup.
• Docs or release notes were updated when needed. (Test only.)
• Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. (No production change.)

Summary by CodeRabbit

• Tests
  • Updated timing for Windows HTTP test scenarios: stalled-body cases use a short deadline, while other cases have more time to complete. This improves the reliability of test results without changing end-user functionality.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-28T20:30:33.269406Z	2e439c3	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[github-actions]

✅ Deterministic PR hygiene checks passed.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: lidge-jun/opencodex
• Branch: fix/windows-child-http-test-budget
• File: .coderabbit.yaml
• Commit: 2e439c3
• Layers: Repository YAML
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 4d2c1b8f-dd8c-4ee8-8ebf-d7c8e1a82d8a

Commits

Reviewing files that changed from the base of the PR and between 53a98e9 and 2e439c3.

Files selected for processing: 1

• tests/clients/link-ssh-argv-discovery.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The Child HTTP test now uses a 250 ms deadline for the stalled-body scenario and a 10-second deadline for all other scenarios.

Changes: Child HTTP test deadlines

Layer / File(s)	Summary
Scenario-specific deadline tests/clients/link-ssh-argv-discovery.test.ts	The test sets a 250 ms deadline for the stalled-body scenario and a 10-second deadline for other scenarios.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to 2e439

The scenario-specific deadlines match the established Windows Child HTTP contract and are ready to merge.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: preventing the Windows Child HTTP success case from using the inappropriate 250 ms deadline.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}