Repository navigation
fix(google,cursor): isolate Antigravity session/replay and Cursor H2 pool/JWT sub scope - #7842
Conversation
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb24f2097e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const scope = parsed._reasoningReplayScope?.current?.credentialDurableIdentity?.trim() | ||
| || parsed._reasoningReplayScope?.current?.credentialIdentity?.trim() | ||
| || accountScope?.trim() | ||
| || ""; | ||
| const preimage = scope ? `acct:${scope}\0${text}` : text; |
There was a problem hiding this comment.
Update the owned architecture docs for the new isolation contract
This changes the credential boundary of Antigravity session/replay identity, while the Cursor changes also alter discovery-pool ownership and fallback checkpoint identity, but the commit updates no structure/ documentation. The mapped architecture docs therefore omit the new credential-scoping and refresh-stability contracts that future changes need to preserve. Update the applicable documents identified by structure/INDEX.md in this commit; src/AGENTS.md explicitly requires those documentation updates alongside changes to owned adapter, transport, and authentication areas.
AGENTS.md reference: src/AGENTS.md:L11-L11
Useful? React with 👍 / 👎.
|
✅ Deterministic PR hygiene checks passed. |
…ession/device IDs (wp1)
…unt switch, and align JSON token refresh (wp2)
…pool/JWT sub scope (wp3)
f28e256 to
94c37d1
Compare
eb24f20 to
67ef1d0
Compare
Summary
google-antigravity)antigravitySessionIdper bound credential identity (_reasoningReplayScope.current) or explicitaccountScopewhile preserving single-arg fallback, and filter thecontext_engineering_is_the_way_to_gobypass sentinel inisLikelyRealThoughtSignatureandextractSignature.thinkingBudget/thinking_budgetincompileGoogleWireBodywhenthinkingLevelis absent.subfromid_tokenintoaccountId, forward the defaulttier_idfromloadCodeAssist.allowedTierstoonboardUser, and surface structured(invalid_grant)on token refresh failures without leakingerror_descriptioninsrc/oauth/google-antigravity.ts.CursorH2SessionPoolentries by(origin, credentialScope)insrc/adapters/cursor/h2-pool.tsandlive-models.ts, unifyCURSOR_DISCOVERY_CLIENT_VERSIONwithcli-2026.07.08-0c04a8a, anchor fallback_cursorIdentityScopeto the JWTsubclaim insrc/adapters/cursor.tsso token refresh preserves checkpoints, addx-cursor-streaming: trueinhttp1-bidi.ts, and remove the giveawayopencodex-quotaUser-Agent invendor-probes-oauth.ts.Verification
env -u GOOGLE_ANTIGRAVITY_USER_AGENT bun test tests/adapters/google/google-antigravity-wire.test.ts tests/adapters/google/google-antigravity-replay.test.ts tests/adapters/google/google-wire-compiler.test.ts tests/adapters/google/google-antigravity-oauth.test.ts tests/providers/cursor/cursor-adapter.test.ts tests/providers/cursor/cursor-discovery.test.ts tests/providers/cursor/cursor-h2-pool-shutdown.test.ts tests/responses/responses-account-change-scrub.test.ts(234 pass, 0 fail)bun run typecheck(exit 0)bun run privacy:scan(Privacy scan passed)bun run structure:check(structure/ SSOT checks passed)Checklist