Repository navigation
fix(compaction): preserve hosted search metadata as text - #6746
yuanyuanlove wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
…s in portable summaries (carry #6746) (#6799) * fix(compaction): omit hosted search replay from portable summaries * fix(compaction): preserve hosted search metadata as text * fix(compaction): bound hosted search notes and keep them assistant reference text * fix(compaction): collect only the capped search note list entries --------- Co-authored-by: panyuanyuan <panyuanyuan@hetao101.com>
|
Thank you, @yuanyuanlove! This fix landed on |
Summary
Portable compaction removes tool declarations before asking another model for a summary. Replaying hosted
web_search_callitems without their tool declaration can then make the upstream reject the request.This change projects remaining hosted search items into clearly labeled, untrusted historical reference text, after bridge restoration. It preserves their position and allowlisted status, query, URL, find pattern and source metadata; unknown/opaque fields are omitted. The text is explicitly not instructions or fetched page content. Existing messages, citations and real bridge-restored call/result pairs remain intact. Stored source history, ordinary generation and canonical native compaction are unchanged.
Responses Lite portable summaries also retain
parallel_tool_calls=false: removing it while forwarding the Lite header causes an upstream 400 even with no callable tools. Non-Lite summaries continue omitting that field.Related investigation: openai/codex#51962. This PR addresses OpenCodex's portable summarizer projection, not the separate native-client history compatibility case. Local Auto Fast catalog opt-in is not included in this PR.
Verification
bun test tests/responses/responses-compaction-override.test.ts tests/web-search/web-search-bridge-replay.test.ts— 81 pass / 0 fail.bun test tests/responses/responses-compaction-routing.test.ts tests/responses/responses-compaction-recovery.test.ts tests/ci-workflows/file-size-ratchet.test.ts— 190 pass / 0 fail.AZURE-KITE-731, 17. This exercised text conversion rather than the previous deletion behavior.OCX_TEST_RUNNER_BUN=<Bun 1.4.0> bun run test:changedrun on the text-conversion candidate, before the final Lite flag fix, completed 15825 pass / 34 skip / 174 fail / 13 errors, 687 files. It is not green. 84 unique failure titles match the earlier run, and there are 86 different failure titles, including timeouts; the new differences have not all been baseline-classified. No compaction test failed in that run. An earlier unmodifiedaeebf11e5baseline reproduced 80 prior failures; this does not establish that every current failure is inherited. The final Lite change was verified with the focused/related suites and real smoke above. No full-suite pass claim; keep Draft pending broader validation and review.origin/devwas fetched and verified as an ancestor:aeebf11e5a2c49b5f2edb2e0d8ecafd95e872119. No unrelated local overlay or catalog changes included.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met: