Repository navigation
feat(cli): guide recovery from command typos - #6503
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (25)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe CLI now provides bounded suggestions for unknown commands and unavailable help paths. Unknown roots are rejected before shim preflight. The changes also update CLI documentation, tests, and work-unit records. ChangesCLI help recovery
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant runCli
participant findCommand
participant printUnknownCommand
participant formatHelpRecovery
participant suggestHelpPaths
participant helpRecoveryCandidates
participant stderr
runCli->>findCommand: Check root command
runCli->>printUnknownCommand: Report unrecognized root
printUnknownCommand->>formatHelpRecovery: Format command path
formatHelpRecovery->>suggestHelpPaths: Find recovery suggestions
suggestHelpPaths->>helpRecoveryCandidates: Get documented candidates
printUnknownCommand->>stderr: Write diagnostic
Merge Risk: ⚪ Minimal · up to The CLI recovery change has no identified merge-blocking issue. The incomplete local full-suite result remains a validation limitation, not a demonstrated regression from this change. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The inspected recovery flow provides bounded guidance without executing suggestions, exposing hidden commands through suggestions, or entering shim preflight for unknown roots. No introduced security issue was established. The exact target-branch comparison and broader validation coverage remain incomplete, leaving limited residual uncertainty. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 28.57% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 8 files. (10 skipped: 10 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
43b31b6 to
d642e2f
Compare
aaf3672 to
13c0e82
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
ocx modlessuggestsocx help models; nested suggestions stay within the known family. Suggestions are never executed.codex/cli-ux-navigation; review only the recovery layer. No client support or runtime provider changes.Manual stack (bottom to top)
Integration proceeds bottom-up under the owner's explicit merge request. Local full-suite limitations remain disclosed below.
Verification
bun run test:changed: 1,113 passed, 1 skipped, 0 failed across 48 files.011_verification.md; three reproduce on untouched baseline, and the snapshot EISDIR failure remains unresolved. This is not a full macOS validation or merge-readiness claim. Each PR's current-head CI is checked independently.Final publication verification: head
5ffef49be2d42befb7404eb5309b8f7f97e039df; Cross-platform CI run 37116552538 (pull_request, attempt 1) completed successfully with all four Linux test shards andci. The checkout tested by shard 1 wasd5eb8d29c149a873f61b1017e370cc183c353c4d. Policy-skipped platform jobs are not claimed as passing platform validation.Checklist
Integration status
The owner explicitly requested merging the complete manual stack. This PR will be retargeted to
devafter its predecessor lands; any refreshed head must pass hosted CI before integration. The prior local full-suite failures remain disclosed and are not claimed as a pass.Local-suite failure attribution
All four previously recorded local-suite failures now reproduce on untouched baseline
4b98328dca. The three restart-lease failures were already baseline-confirmed. The remainingEISDIRis intests/codex-integration/injection-model-suggest-routes.test.ts:100, before the tested request: setup calls the bundled Codex catalog probe, whosecodex debug models --bundledsubprocess createsCODEX_HOME/tmp; the shallow snapshot attempts to read that directory as a file. The unchanged baseline test reproduced the identical failure in an isolated home. A controlled inherited-home / redirected-home / inherited-home experiment producedtmponly in the selected subprocess home. The baseline fixture matches Git blobef0dafba8dfe2cff3b7519453502d95a46b64925; the fixture and direct catalog producer are unchanged by this stack.This closes the previously unexplained attribution gap; it does not turn the failed full local run into a pass. No test skip, quarantine or retry-as-fix was added. Merge still requires successful current-head hosted CI and resolution of actionable reviews.
Maintainer integration
The owner explicitly requested completion through merge. Integrating into
devunderMAINTAINERS.mdas authenticated current maintainerlidge-junwith live admin permission; this is not a self-approval. Earlier draft-only status records the original publication state and is superseded by this integration decision. All four local full-suite failures are baseline-reproduced as documented above; no local full-suite pass is claimed. The provider usage correction is included through parent #6500.Final head
53d64d3f03515bb861d1474f126c5d1f60a67075passed Cross-platform CI 37126906980 (pull_request, attempt 1), including all four Linux test shards, docs/structure gates, package smokes and aggregateci. Tested checkout2eaee34b3723df5fc81618d34f4d9910218530fahas treeb3d021ccab21c29c6e3bdc656fcda4cba43fce51, identical to the conflict-free prospective merge with devcb2d1736a858a69b3d95944d531f48b93c2f56a5after #6500. Superseded canceled runs and policy-skipped platform jobs are not represented as passing validation.Summary by CodeRabbit