Repository navigation
Pin CI mdtablefix to 0.6.1 - #879
Conversation
0.6.1 fixes the 0.6.0 bugs that changed Markdown content: --wrap breaking text with no whitespace, Setext headings rewritten as rules, and --renumber changing a list's start. make check-fmt passes unchanged on main with 0.6.1.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis mechanical CI-only change consistently pins mdtablefix to 0.6.1 in the workflow-level environment and Windows reusable-workflow input, retaining the equality contract and avoiding any documentation or Markdown reformat changes. The reported validation confirms both the formatting check and workflow contract tests pass. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. Summary
Validation
WalkthroughThe CI workflow updates its mdtablefix version pin and the version passed to the Windows reusable workflow from 0.6.0 to 0.6.1. ChangesCI version update
Priority: ⬇️ Low Change: Other Merge Risk: ⚪ Minimal · up to The CI pin is consistently updated to mdtablefix 0.6.1, including the Windows installer path. No actionable merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Set the version to six-one, Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 606adc2061
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| with: | ||
| nextest-version: '0.9.133' | ||
| mdtablefix-version: '0.6.0' | ||
| mdtablefix-version: '0.6.1' |
There was a problem hiding this comment.
Invalidate the Windows tools cache for the new pin
When a Windows tools cache containing mdtablefix 0.6.0 already exists, changing this caller-side literal does not change its cache key: .github/actions/windows-gate-cache/action.yml hashes only itself and ci-windows.yml. The installer therefore replaces the stale executable with 0.6.1, but the exact restore still reports a cache hit and the save condition refuses to publish the updated directory. Consequently every Windows lint run repeats the external mdtablefix download until some unrelated hashed file changes; include the caller pin in the Windows tools key or otherwise force a new generation.
Useful? React with 👍 / 👎.
Points every install-mdtablefix reference at shared-actions 0606ca89, the current main, so the repository installs mdtablefix through the current action.
Moves CI's mdtablefix pin from 0.6.0 to 0.6.1 in
.github/workflows/ci.yml: the workflow-levelMDTABLEFIX_VERSIONand the literalmdtablefix-versionpassed to the Windows reusable workflow (the two are held equal bytests/workflow_contracts/ci_windows_job_test.py).0.6.1 (29 September) fixes the 0.6.0 bugs that changed Markdown content:
--wrapbreaking text with no whitespace, Setext headings turned into rules, and--renumberchanging a list's start.The developer docs (
docs/developers-guide.md,AGENTS.md,Makefile) read the pin from the workflow, and their "0.6.0 or later" text states the first release with--checkand--git, which is still true, so they are unchanged.Measurement: on a clean checkout of main at 27d7ead,
mdtablefix 0.6.1with the exactmake check-fmtcommand (mdtablefix --check --git --include-untracked --wrap --renumber --breaks --ellipsis --fences) reports "172 files left unchanged", exit 0. No Markdown reformat is needed.Validation:
make test-workflow-contractspasses (1149 passed, 3 skipped; 27 passed).This is a mechanical pin-only repin with a contract, so it merges on green at the exact head without a CodeRabbit review.
Overlap: open netsuke PRs #621, #816, #834 and #835 (the user's or the robot house's) do not touch these lines; I have not touched them.
Summary by Sourcery
Update CI to use mdtablefix 0.6.1 consistently across all workflow lanes.
Enhancements:
CI: