[leynos]

Summary

Align whole-manifest cycle detection with the build graph. The detector follows
explicit sources, implicit deps, and order_only_deps, and resolves
explicit and implicit output aliases to their producing edge. Human diagnostics
show the localized cycle path; tracing records only a fixed error category. The
JSON diagnostic envelope is unchanged.

Contract and compatibility

• ADR-0060
  records why every prerequisite kind participates in whole-manifest cycle
  detection; dependency_order: serial remains a scheduling policy that adds
  no dependency arc.
• This is a breaking behaviour change: an order-only cycle is rejected even
  when its targets are not requested. The v0.1.0 migration guide explains how
  to remove the back edge.
• Unit, property, BDD, end-to-end, and Kani coverage exercise order-only
  cycles, implicit-output aliases, missing paths, serial ordering, and the
  human and JSON diagnostics.
• Proposed follow-up D7: add the dependency kind that closes the cycle to the
  diagnostic. No issue is filed without maintainer agreement.

Validation

• make check-fmt, make lint, make typecheck, and make doc-coverage
  passed; doc coverage is 98.19%.
• make test passed 4,742 tests with 7 skipped; doctests passed.
• make markdownlint passed for 202 files with zero issues; make nixie,
  make test-documentation-contracts (15 passed), and
  make test-workflow-contracts (1,351 passed, 3 skipped, plus 27 script
  tests) passed.
• The capped make kani-ir run passed all 17 harnesses.

References

• Roadmap item 4.4.2
• Approved ExecPlan
• ADR-0060

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[sourcery-ai]

Reviewer's Guide

Adds a plan-only ExecPlan for documenting and implementing cycle-detection semantics: order-only dependencies will become cycle-detection edges, implicit outputs will be explicitly documented and tested, serial ordering will remain outside the dependency graph, and the behavior will be covered by implementation, verification, documentation, and migration work.

Sequence diagram for order-only cycle rejection

sequenceDiagram
    participant User
    participant Netsuke
    participant IR as IR validation
    participant Ninja
    User->>Netsuke: generate or build manifest
    Netsuke->>IR: BuildGraph.detect_cycles()
    IR->>IR: visit_known_edge()
    IR->>IR: visit_dependencies(order_only_deps)
    alt cycle detected
        IR-->>Netsuke: CircularDependency
        Netsuke-->>User: localized diagnostic / JSON error
        Netsuke-->>Ninja: no Ninja invocation
    else no cycle
        IR-->>Netsuke: validated graph
        Netsuke->>Ninja: generate or run build
    end

Loading

Flow diagram for dependency-kind participation

flowchart TD
    Start[Dependency graph validation] --> Kinds{Dependency kind}
    Kinds -->|sources| Traverse[Traverse dependency edge]
    Kinds -->|deps| Traverse
    Kinds -->|order_only_deps| Traverse
    Traverse --> Cycle{Back edge found?}
    Cycle -->|yes| Reject[Reject with CircularDependency]
    Cycle -->|no| Continue[Continue graph validation]
    Alias[Explicit or implicit output alias] --> Resolve[Resolve producing edge]
    Resolve --> Traverse
    Serial[dependency_order: serial] -. adds no edge .-> Continue

Loading

File-Level Changes

Change	Details	Files
Adds a detailed execution plan for aligning Netsuke's cycle-detection scope with Ninja semantics.	Decides that order_only_deps participate in whole-manifest cycle detection and records the breaking compatibility impact. Specifies characterization coverage for implicit-output aliases and confirms dependency_order: serial contributes no graph edges. Defines the implementation change to traverse order-only dependencies and the associated unit, property, Kani, BDD, and end-to-end tests. Plans consistent updates to the users' guide, ADR-041, design and verification documents, developer documentation, changelog, migration guide, roadmap, and contents index. Defines staged milestones, acceptance criteria, mutation evidence, quality gates, risks, constraints, and rollback/recovery procedures.	docs/execplans/4-4-2-document-cycle-detection-scope.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.