Skip to content

fix: bump RPC protocol patch version for rope apply op - #2115

Merged
leejet merged 1 commit into
masterfrom
fix/rpc-protocol-op-count
Oct 9, 2026
Merged

leejet merged 1 commit into
masterfrom
fix/rpc-protocol-op-count

Conversation

@leejet

@leejet leejet commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Fix RPC compilation after adding GGML_OP_ROPE_APPLY by updating the expected GGML_OP_COUNT from 104 to 105.
  • Bump RPC_PROTO_PATCH_VERSION from 2 to 3.

Related Issue / Discussion

Fix #2114.

Additional Information

N/A

Checklist

Summary by CodeRabbit

  • Chores
    • Updated the ggml subproject reference.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 702f19d7-dbe3-40bb-be4b-f36a71177c2c

📥 Commits

Reviewing files that changed from the base of the PR and between 228c707 and c134085.


📒 Files selected for processing (1)
  • ggml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.



📝 Walkthrough

Walkthrough

The ggml subproject reference changed from commit 66c1a2876031613788054a394bafb08d2e9f42dc to d25b121ce1d6ae0c7e62ad080460d9fc1e46dd93.

Changes

ggml Revision Update

Layer / File(s) Summary
Update ggml subproject reference
ggml
The pinned ggml commit changed to d25b121ce1d6ae0c7e62ad080460d9fc1e46dd93.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix · Severity of issue fixed: Medium


Merge Risk: ⚪ Minimal · up to c1340

The RPC build mismatch is resolved by the updated dependency revision.

Architecture Summary

Architecture risk: 🔵 Low · up to c1340

The change affects 1 system.

Changed systems: ggml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — ggml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in ggml: The ggml subproject commit reference was updated from 66c1a2876031613788054a394bafb08d2e9f42dc to d25b121ce1d6ae0c7e62ad080460d9fc1e46dd93.

🚥 Pre-merge checks | ✅ 4 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check Inconclusive Issue #2114 requires the RPC build fix: GGML_OP_COUNT must change from 104 to 105, and RPC_PROTO_PATCH_VERSION must change from 2 to 3. The whole-PR diff changes only the ggml submodule pointer … Provide reviewable evidence from ggml commit d25b121 that ggml-rpc.h contains the expected count 105 and protocol patch version 3, or make those changes reviewable in the pull request.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the main change: bumping the RPC protocol patch version for the rope apply operation.
Description check Passed The description follows the repository template. It explains the changes and reason, references issue #2114, includes additional information, and confirms the contribution checklist.
Out of Scope Changes check Passed The whole-PR diff contains only the ggml submodule pointer update. This change directly targets the RPC protocol and operation-count mismatch described in issue #2114. No unrelated changes are shown…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

Full details: Linked Issues check

Explanation

Issue #2114 requires the RPC build fix: GGML_OP_COUNT must change from 104 to 105, and RPC_PROTO_PATCH_VERSION must change from 2 to 3. The whole-PR diff changes only the ggml submodule pointer from 66c1a28 to d25b121. The submodule contents are not present in the reviewed repository, so the required declarations and build fix cannot be verified.



✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@leejet
leejet merged commit 7867f6d into master Oct 9, 2026
11 checks passed
@leejet
leejet deleted the fix/rpc-protocol-op-count branch October 9, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] RPC build broken at HEAD: static assertion GGML_OP_COUNT (66c1a28 added GGML_OP_ROPE_APPLY without bumping RPC proto version)

1 participant