Carry the D type alignment on struct init memset - #5290
Open
thewilsonator wants to merge 2 commits into
Open
thewilsonator wants to merge 2 commits into
thewilsonator wants to merge 2 commits into
Conversation
thewilsonator
marked this pull request as ready for review
September 11, 2026 05:27
thewilsonator
force-pushed
the
struct-memset-align
branch
from
September 16, 2026 08:34
4a18af0 to
e0489a5
Compare
Member
|
I think this is pretty safe, as runtime-initializing an under-aligned variable seems exotic, e.g., I'd strongly suggest a |
Fission of ldc-developers#5279 to see what causes the problems with it
thewilsonator
force-pushed
the
struct-memset-align
branch
from
September 18, 2026 06:20
e0489a5 to
72f59eb
Compare
Member
But if we now start to miscompile such code, we should error on code like that. Otherwise it may lead to very hard to track down bugs. Full example: struct S { int a; } // implicit align(4)
void foo() {
bool b;
align(1) S s; // miscompiled with this PR because the _type's_ alignment is used, not the variable's alignment.
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fission of #5279 to see what causes the problems with it