Skip to content

fix(sdk-client-common): identify() bootstrap does not set flagstore in FDv2 - #1837

Open
joker23 wants to merge 1 commit into
mainfrom
skz/sdk-2827/fdv2-identify-bootstrap
Open

fix(sdk-client-common): identify() bootstrap does not set flagstore in FDv2#1837
joker23 wants to merge 1 commit into
mainfrom
skz/sdk-2827/fdv2-identify-bootstrap

Conversation

@joker23

@joker23 joker23 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

This PR will fix per-context bootstrap behavior for FDv2.


Note

Medium Risk
Changes identify/bootstrap flag-store wiring for FDv2; incorrect parsing or context mapping would break per-context evaluations, but scope is limited and covered by new tests.

Overview
FDv2 identify() now loads bootstrap into the per-context flag store instead of assuming the caller already applied it (e.g. via presetFlags before identify).

When identifyOptions.bootstrap is present, FDv2DataManagerBase parses it with readFlagsFromBootstrap (or uses pre-parsed bootstrapParsed) and calls flagManager.setBootstrap(context, …) for the identified context, then resolves identify immediately as before.

Tests cover setBootstrap on first identify and on re-identify with updated bootstrap payloads.

Reviewed by Cursor Bugbot for commit 17186ea. Bugbot is set up for automated code reviews on this repo. Configure here.

FDv2

This PR will fix per-context bootstrap behavior for FDv2.
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26360 bytes
Compressed size limit: 29000
Uncompressed size: 129188 bytes

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 32099 bytes
Compressed size limit: 34000
Uncompressed size: 114604 bytes

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 39099 bytes
Compressed size limit: 39300
Uncompressed size: 213748 bytes

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179745 bytes
Compressed size limit: 200000
Uncompressed size: 831788 bytes

@joker23

joker23 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 17186ea. Configure here.

@joker23
joker23 marked this pull request as ready for review August 4, 2026 15:15
@joker23
joker23 requested a review from a team as a code owner August 4, 2026 15:15

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant