Adding tool factories for the agentcore memory store - #667
Open
Jack Gordley (jgordley) wants to merge 3 commits into
Open
Adding tool factories for the agentcore memory store#667Jack Gordley (jgordley) wants to merge 3 commits into
Jack Gordley (jgordley) wants to merge 3 commits into
Conversation
|
My thinking is, we designed our system so that CreateEvent should always be called for all LLM messages, and then the decision to extract a memory record from the message belongs to our service backend. So then I can see it being more straightforward for the customer if we just tell them: "Store all messages," and so if we take that stance, it would imply that we don't want to have a tool for calling CreateEvent (since then it confuses customers into adopting the anti-pattern where they don't store all events) |
Contributor
|
Hey bergjaak , just to follow up and summarize what we talked about, I think users will want all of the following:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds LangMem style tool factories to provide to the agent for saving events and searching for memories at runtime.
It is based on the LangMem tool factories with the ability to inject the base store at runtime and use the runtime config
actor_idandsession_idto save and search for memories according to the runtime config.Reference implementation: https://github.com/langchain-ai/langmem/blob/main/src/langmem/knowledge/tools.py
Comes with a sample notebook.